docs(alerts and reports): Update ExecutorType class

[mrmooon]

SUMMARY

I was setting up ALERT_REPORTS_EXECUTE_AS following the current documentation and realized that the Enum was renamed from ReportScheduleExecutor to ExecutorType and moved into superset.tasks.types in #22328 by @villebro.

I've just updated that bit of the docs to reflect those changes and the comments in the config.py file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshots from the Alerts and Reports docs.

Before

After

TESTING INSTRUCTIONS

Spin up the local docs site

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[villebro]

Thanks for fixing this and apologies for the oversight, I thought I had updated all relevant parts 🙁

[codecov]

Codecov Report

Merging #23323 (644c6f2) into master (57db8f9) will increase coverage by 1.66%.
The diff coverage is n/a.

❗ Current head 644c6f2 differs from pull request most recent head af8b869. Consider uploading reports for the commit af8b869 to get more accurate results

@@            Coverage Diff             @@
##           master   #23323      +/-   ##
==========================================
+ Coverage   65.86%   67.53%   +1.66%     
==========================================
  Files        1909     1909              
  Lines       73491    73491              
  Branches     7988     7988              
==========================================
+ Hits        48404    49631    +1227     
+ Misses      23037    21810    -1227     
  Partials     2050     2050              

Flag	Coverage Δ
hive	52.77% <ø> (ø)
mysql	78.44% <ø> (ø)
postgres	78.50% <ø> (ø)
presto	52.70% <ø> (?)
python	82.28% <ø> (+3.46%)	⬆️
sqlite	76.98% <ø> (ø)
unit	52.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	91.78% <ø> (ø)

... and 87 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[mrmooon]

Thanks for fixing this and apologies for the oversight, I thought I had updated all relevant parts 🙁

No worries! it was cool for taking a look at the codebase 🙂 (and the ping was just intended for your visibility)

[villebro]

No worries! it was cool for taking a look at the codebase 🙂 (and the ping was just intended for your visibility)

Great! 🙂 Thanks for pinging me, I might have missed this otherwise 👍 Btw, I tried to make this feature as generic and customizable as possible, but let me know if it doesn't fit your use case so we can see if we can extend it further.

[mrmooon]

Great! 🙂 Thanks for pinging me, I might have missed this otherwise 👍 Btw, I tried to make this feature as generic and customizable as possible, but let me know if it doesn't fit your use case so we can see if we can extend it further.

Thanks! Yup! It looks great tbh, we're testing it atm but so far it has worked flawlessly 🚀

[circobit]

@mrmooon @villebro Hey, folks. Thanks for updating the doc. I'm reaching out to ask if you have had the chance to test it as I'm getting the following error when adding the parameters for ALERT_REPORTS_EXECUTE_AS:

ModuleNotFoundError: No module named 'superset.tasks.types'

Checking in the repo I see the class ExecutorType declared in superset/superset/tasks/types.py so it looks OK, but somehow the workers trying to fetch it is not able to find it. Any feedback would be very much appreciated, thank you for your time.

For context, this is what I'm setting in my_override:

from superset.tasks.types import ExecutorType

# Execute alerts impersonating the following users in the order they are listed
ALERT_REPORTS_EXECUTE_AS = [
    ExecutorType.CREATOR_OWNER,
    ExecutorType.CREATOR,
    ExecutorType.MODIFIER_OWNER,
    ExecutorType.MODIFIER,
    ExecutorType.OWNER,
    ExecutorType.SELENIUM,
]

[mrmooon]

Hey @cristian-cevasco! This feature will be part of version 2.1.0 which doesn't have a stable release for now (the third RC is currently being discussed). I wonder if it could be related to that, could you confirm that you're using that version, please? 🤔