fix(ssh_tunnel): Fix bug on database edition for databases with ssh tunnels

[Antonio-RiveroMartnez]

SUMMARY

• If the SSH_TUNNELING feature flag is OFF no SSH Tunnel Switch or the rest of the form fields must be visible in the DatabaseModal, however, that's not happening when editing a DB. Add test that check that if no switch is in the document, then the rest of fields must not be in the document.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Make sure your SSH_TUNNELING flag is OFF
2. Open the edit modal on a DB that has SSH Tunnel attached to it
3. The SSH Tunnel switch must not be visible
4. The rest of SSH Tunnel form fields must not be visible

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[lyndsiWilliams]

I left a comment on a non-blocking nit, otherwise this looks great!

[codecov]

Codecov Report

Merging #23006 (7da15a3) into master (7a0f350) will increase coverage by 14.05%.
The diff coverage is 88.23%.

❗ Current head 7da15a3 differs from pull request most recent head 5f6da7f. Consider uploading reports for the commit 5f6da7f to get more accurate results

@@             Coverage Diff             @@
##           master   #23006       +/-   ##
===========================================
+ Coverage   53.23%   67.29%   +14.05%     
===========================================
  Files        1878     1878               
  Lines       72132    72137        +5     
  Branches     7864     7866        +2     
===========================================
+ Hits        38402    48541    +10139     
+ Misses      31711    21577    -10134     
  Partials     2019     2019               

Flag	Coverage Δ
javascript	53.81% <85.71%> (+<0.01%)	⬆️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e/components/controls/MetricControl/AdhocMetric.js	95.65% <ø> (-0.10%)	⬇️
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx	78.04% <ø> (ø)
superset/models/helpers.py	38.02% <ø> (+11.94%)	⬆️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx	80.39% <80.00%> (+0.60%)	⬆️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx	47.45% <100.00%> (ø)
...s/controls/MetricControl/MetricDefinitionValue.jsx	100.00% <100.00%> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx	34.44% <100.00%> (-0.73%)	⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx	45.29% <100.00%> (ø)
superset/connectors/sqla/models.py	88.08% <100.00%> (+14.59%)	⬆️
superset/db_engine_specs/base.py	90.29% <100.00%> (+27.88%)	⬆️
... and 353 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Antonio-RiveroMartnez]

I left a comment on a non-blocking nit, otherwise this looks great!

Thanks! PR updated with the suggestion 🙌