Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graph): graph page error #13395

Closed
wants to merge 35 commits into from
Closed

fix(graph): graph page error #13395

wants to merge 35 commits into from

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 1, 2021 •
edited
Loading

Bug review reported here: #13210 (comment)

When entering a new chart, an error occurs and the application freezes.
The error message points out that it is because an array is expected but an object is being sent.
As shown in the image:
Captura de Tela 2021-03-01 às 6 55 17 PM

With this fix, I started to send the object's values as an array:
Captura de Tela 2021-03-01 às 6 57 44 PM

The application stopped freezing, but I was unable to test if it is working correctly:
Captura de Tela 2021-03-01 às 7 01 16 PM

Attention points:

  • There are several incorrect typing alerts in this flow.
  • Some typescript components are also incorrectly typed. (Missing properties that are being used in other components. "options" was one of those properties that was missing.
  • Perhaps this fix can generate some unwanted side effects on others charts. Before deciding whether it actually solved anything, it is important to check if the others charts are working correctly.
  • Component that was giving exception and freezing the application: src/explore/components/Control.tsx

My guess:
When activating the Feature Flag, some changes in the response of the APIS started to cause this unwanted behavior.

@yardz yardz marked this pull request as draft March 1, 2021 22:14
@junlincc junlincc changed the title Bug chart fix(graph): graph page error Mar 1, 2021
zhaoyongjie and others added 4 commits March 2, 2021 07:50
@zhaoyongjie
feat(viz): implement time picker on filter box (apache#13377)
488da65 
* refactor(explore): restructure DateFilterControl

* fix UT

* remove datasource props

* remove unused files

* fix DateFilterControl in filterbox over length
@simcha90
refactor(self-trigger): Split native filters state (apache#13137)
f19a830 
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* feat: POC adding filters set feature

* chore: pre-commit

* refactor: under chage

* lint: fix TS

* fix: fix FF name

* refactor: move to behaviors

* lint: fix lint

* refactor: update state of native filters

* refactor: finish refactor nativeFilter state

* feat: split native filters state

* refactor: refactor Time filter to use new API

* refactor: refactor Time filter to use new API

* refactor: fix CR notes

* fix: fix update values in filter bar

* refactor: save filter sets in meta

* feat(filter-sets): save filters sets in metadata

* refactor: partially fix ts

* refactor: merge conflicts

* refactor: add behaviors property

* refactor: add behaviors property

* fix: undo py changes

* fix: under some changes

* refactor: synx with master

* fix: undo FF

* fix: undo FF

* lint: ts-ignore

* chore: update lock file

* refactor: update enum

* refactor: naming of enum

* test: fix test

* test: update mocks

Co-authored-by: amitmiran137 <[email protected]>
@iercan
fix(alerts&reports): Alerts & Reports will use values from WEBDRIVER_…
b04aebf 
…WINDOW option (apache#13157)

* fix: thumbnails and reports will be use WEBDRIVER_WINDOW option

* changes reformatted

* config change reverted. thumbnails sizes changed to original

* typo fix

* bugfix

defining defaults in thumbnails.py caused thumbnail caches invalidated.
they moved to init.

Co-authored-by: Ibrahim Ercan <[email protected]>
@villebro
chore: bump pyarrow and pandas (apache#12882)
70e12ed 
* bump pyarrow and pandas

* remove df copy
@junlincc
Copy link
Member

junlincc commented Mar 2, 2021

LGTM from UI with the feature flag on and off.
Let's update the PR description and get the checks green.

ktmud and others added 19 commits March 2, 2021 15:58
@ktmud
chore: convert chartReducer to TypeScript (apache#13374)
f261629
@john-bodley
fix(query-object): extra time-range-endpoints (apache#13331)
694ae6f 
Co-authored-by: John Bodley <[email protected]>
@geido
test: ErrorMessage components tests (apache#13358)
7d270bc 
* Add tests for ErrorAlert

* Add BasicErrorAlert tests

* Add DatabaseErrorMessage tests

* Add useRedux property

* Finalize DatabaseErrorMessage tests

* Add ErrorMessageWithStackTrace tests

* Move getErrorMessageComponentRegistry test to dedicated directory

* Clean up getErrorMessageComponentRegistry

* Add IssueCode tests

* Add tests for ParameterErrorMessage

* Add tests for TimeoutErrorMessage

* Fix linting issue
@michael-s-molina
Adds tests and storybook to CopyToClipboard component (apache#13359)
e9d5d3b
@michael-s-molina
test: Adds storybook to EditableTitle component (apache#13362)
45aa812
@michael-s-molina
test: Adds storybook to IconTooltip component (apache#13415)
c3e19b2
@michael-s-molina
test: Adds storybook to AnchorLink component (apache#13406)
51f05ea
@michael-s-molina
test: Adds storybook to FormRow component (apache#13407)
327e9b0
@michael-s-molina
chore: Removes unused Hotkeys component (apache#13408)
65cec18
@simcha90 @amitmiran137
feat(dashboard_rbac): manage roles for dashboard (apache#13145)
dc17039 
* feat(dashboard_rbac): manage roles for dashboard

* test: fix tests

* fix: fix empty roles

Co-authored-by: Amit Miran <[email protected]>
@mayurnewase
changes added (apache#13431)
8b38d63
@srinify
chore: Added rockset and firebird (apache#13418)
26b75fa 
* added URL rerouting from old alerts & reports page to new one

* edited SQL Server, Rockset, db ordering, and link that Superset logo in left corner takes you to

* added Trino logo and firebird connection string and removed bigquery trailing comma

* added ROckset logo

* changed db list ordering for firebird

* tweaked presnetation of firebird connection string
@AAfghahi
feat: Added Rows Returned (apache#13190)
9c9862f
@AAfghahi
refactor: Query search into functional component (apache#13102)
66a7318
@riahk
fix: annotation layer modal err handling (apache#12341)
26e36ae 
* annotation layer modal err handling

* address comments
@eschutho
use semver for badge sort (apache#13424)
026782e
@ktmud
refactor: convert controlUtils to TypeScript (1 of 2) (apache#13401)
dc1eb30
@michael-s-molina
chore: Moves TableSelector tests to component's folder (apache#13411)
cfc83c2
@zhaoyongjie
chore: disable drag metrics and columns in datasourcePanel (apache#13450
ca27b00 
)
simcha90 and others added 10 commits March 4, 2021 10:08
@simcha90
refactor: add set data mask to build query (apache#13417)
7f0fbb5 
* refactor: add set data mask to build query

* refactor: update hooks placement
@tesshy
chore: Improve japannese translation (apache#13376)
6026e7d
@thinkh
docs: Fix typo in footer (apache#13455)
09e5ea1 
The correct spelling is Foundation
@michellethomas
Adding v0 import/export fields to dashboard metadata schema (apache#1…
95809e5 
…3425)

Co-authored-by: michelle_thomas <[email protected]>
@a5net
chore: Migrating dashboard/components/menu from jsx to tsx (apache#13361
483405f 
)

* fix: constant icon size

* clean up

* dashboard/components/menu jsx -> tsx

* more types

* package-lock.json sync

* package-lock fix

* fix

* lint fix

* added comment about event type
@samtfm
feat: Add error pages (apache#13144)
0318b6d 
* add custom error pages for 404 and 500 responses

* refactor error page styles into separate template

* move error pages to superset-frontend

* fix whitespace on error pages

* refactor error pages to be generated by jinja

* generate static error pages with webpack
@yardz
Enabling feature flag
2a5eb0e
@yardz
"fix"
e840a35
@yardz
Merge branch 'bug-Chart' of github.com:yardz/superset into bug-Chart
c095710
@yardz
Specifying the prop's transformation only in case this error occurred
6a5f9c2
@yardz yardz closed this Mar 4, 2021
@yardz yardz deleted the bug-Chart branch March 4, 2021 19:31
@geido geido added explore Namespace | Anything related to Explore and removed viz:explore:graph labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
explore Namespace | Anything related to Explore size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.