Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Japanese translation #13376

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

tesshy
Copy link
Contributor

@tesshy tesshy commented Mar 1, 2021

SUMMARY

  • Improve Japanese translation, focus on Dashboard view.
    • Some Japanese translations was not matched, so that we improve it with manual work

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #13376 (77249fe) into master (ca27b00) will decrease coverage by 5.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13376      +/-   ##
==========================================
- Coverage   76.55%   71.40%   -5.15%     
==========================================
  Files         906      804     -102     
  Lines       45682    40589    -5093     
  Branches     5515     4155    -1360     
==========================================
- Hits        34972    28984    -5988     
- Misses      10563    11605    +1042     
+ Partials      147        0     -147     
Flag Coverage Δ
cypress 57.96% <ø> (+5.09%) ⬆️
hive ?
javascript ?
mysql 80.32% <ø> (ø)
postgres ?
presto ?
python 80.32% <ø> (-0.54%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/components/ErrorMessage/DatabaseErrorMessage.tsx 0.00% <0.00%> (-94.74%) ⬇️
... and 512 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca27b00...77249fe. Read the comment docs.

@villebro villebro changed the title chore: Improve Japannese translation chore: Improve Japanese translation Mar 1, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tesshy so much for this! 🗾

@junlincc
Copy link
Member

junlincc commented Mar 2, 2021

@tesshy really appreciate your contribution! would you mind getting all tests passed?

@junlincc junlincc added the i18n:japanese Translation related to Japanese language label Mar 2, 2021
@tesshy
Copy link
Contributor Author

tesshy commented Mar 4, 2021

@junlincc Yep, and we use this translation currently at ver.1.0

@villebro
Copy link
Member

villebro commented Mar 4, 2021

@tesshy would you mind rebasing the PR? It seems this might have been cut at a time when there was a bug in the codecov configuration in CI, and that's blocking me from merging the PR.

@tesshy
Copy link
Contributor Author

tesshy commented Mar 4, 2021

@villebro sure, I'll rebase and test it.

@villebro
Copy link
Member

villebro commented Mar 4, 2021

Thanks so much @tesshy!

@villebro villebro merged commit 6026e7d into apache:master Mar 4, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:japanese Translation related to Japanese language 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants