-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve Japanese translation #13376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13376 +/- ##
==========================================
- Coverage 76.55% 71.40% -5.15%
==========================================
Files 906 804 -102
Lines 45682 40589 -5093
Branches 5515 4155 -1360
==========================================
- Hits 34972 28984 -5988
- Misses 10563 11605 +1042
+ Partials 147 0 -147
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tesshy so much for this! 🗾
@tesshy really appreciate your contribution! would you mind getting all tests passed? |
@junlincc Yep, and we use this translation currently at ver.1.0 |
@tesshy would you mind rebasing the PR? It seems this might have been cut at a time when there was a bug in the codecov configuration in CI, and that's blocking me from merging the PR. |
@villebro sure, I'll rebase and test it. |
Thanks so much @tesshy! |
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION