-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(self-trigger): Split native filters state #13137
Conversation
� Conflicts: � superset-frontend/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.ts � superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/utils.ts
� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/utils.ts � superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts
� Conflicts: � superset-frontend/src/explore/components/controls/VizTypeControl.jsx
� Conflicts: � superset-frontend/src/featureFlags.ts � superset/config.py
� Conflicts: � superset-frontend/src/chart/ChartContainer.jsx � superset-frontend/src/chart/ChartRenderer.jsx � superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal/FilterConfigForm.tsx � superset-frontend/src/dashboard/components/nativeFilters/utils.ts � superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts � superset-frontend/src/filters/components/Select/AntdSelectFilter.tsx
� Conflicts: � superset-frontend/spec/fixtures/mockNativeFilters.ts � superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal/FilterConfigForm.tsx � superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx � superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx � superset-frontend/src/filters/components/Select/types.ts � superset-frontend/src/filters/components/Time/TimeFilterPlugin.tsx � superset-frontend/src/filters/components/Time/types.ts
…-superset into private-state � Conflicts: � superset-frontend/spec/fixtures/mockNativeFilters.ts � superset-frontend/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.ts � superset-frontend/src/dashboard/actions/nativeFilters.ts � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterValue.tsx � superset-frontend/src/dashboard/reducers/nativeFilters.ts
� Conflicts: � superset-frontend/spec/fixtures/mockNativeFilters.ts � superset-frontend/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.ts � superset-frontend/src/dashboard/actions/nativeFilters.ts � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx � superset-frontend/src/dashboard/reducers/nativeFilters.ts � superset-frontend/src/dashboard/reducers/types.ts
� Conflicts: � superset-frontend/src/dashboard/actions/nativeFilters.ts � superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx � superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/state.ts
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small type nit
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment with regards to the unitName
- other than that LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #13137 +/- ##
==========================================
- Coverage 77.09% 73.05% -4.04%
==========================================
Files 898 599 -299
Lines 45711 21147 -24564
Branches 5495 5491 -4
==========================================
- Hits 35241 15449 -19792
+ Misses 10344 5571 -4773
- Partials 126 127 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* feat: add cross filters * refactor: fix CR notes * lint: fix lint * lint: fix lint * feat: POC adding filters set feature * chore: pre-commit * refactor: under chage * lint: fix TS * fix: fix FF name * refactor: move to behaviors * lint: fix lint * refactor: update state of native filters * refactor: finish refactor nativeFilter state * feat: split native filters state * refactor: refactor Time filter to use new API * refactor: refactor Time filter to use new API * refactor: fix CR notes * fix: fix update values in filter bar * refactor: save filter sets in meta * feat(filter-sets): save filters sets in metadata * refactor: partially fix ts * refactor: merge conflicts * refactor: add behaviors property * refactor: add behaviors property * fix: undo py changes * fix: under some changes * refactor: synx with master * fix: undo FF * fix: undo FF * lint: ts-ignore * chore: update lock file * refactor: update enum * refactor: naming of enum * test: fix test * test: update mocks Co-authored-by: amitmiran137 <[email protected]>
SUMMARY
Requires: apache-superset/superset-ui#959
This PR split
nativeFilters -> filtersState
to next subdomains:a.
nativeFilters
: save data for native filters itselfb.
crossFilters
: save filter for cross filters functionalityc.
ownFilters
every chart can save here custom data (like table plugin BE pagination: feat(self-trigger): add backend pagination for the table apache-superset/superset-ui#959)Re-trigger chart rendering if
own
extraFormData
changed for some specific chartApply change from feat(self-trigger): add backend pagination for the table apache-superset/superset-ui#959 to change hook
setExtraFormData
tosetDataMask
(also related to splitting ofnativeFilters
state)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-02-15.at.19.22.59.mov
TEST PLAN
ADDITIONAL INFORMATION