Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urls describing why NIOFS is not recommended for Windows #14081

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

YeonghyeonKO
Copy link

@YeonghyeonKO YeonghyeonKO commented Dec 19, 2024

Description

  • Lucene decides to open segment files whether JRE_IS_64BIT is true or false as below:
  public static FSDirectory open(Path path, LockFactory lockFactory) throws IOException {
    if (Constants.JRE_IS_64BIT) {
      return new MMapDirectory(path, lockFactory);
    } else {
      return new NIOFSDirectory(path, lockFactory);
    }
  }
  • In FSDirectory.java and NIOFSDirectory.java, there are url links describing why NIOFSDirectory is not appropriate way to open file only for Windows. Unfortunately these have no longer been valid url, so I fixed them in this PR.

Copy link
Member

@danmuzi danmuzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch! 👍

@@ -31,7 +31,7 @@ Bug Fixes

Other
---------------------
(No changes)
* GITHUB#14081: Fix urls describing why NIOFS is not recommended for Windows (Marcel Yeonghyeon Ko)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this patch in Lucene 10.2.0 :)
(Merge into the main -> cherry-pick to the branch_10x)
Lucene 11 is a long way from being released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmuzi Thanks for reviewing my PR. I fixed CHANGES.txt to include in Lucene 10.2

@YeonghyeonKO YeonghyeonKO requested a review from danmuzi December 23, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants