-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix urls describing why NIOFS is not recommended for Windows #14081
Fix urls describing why NIOFS is not recommended for Windows #14081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patch! 👍
lucene/CHANGES.txt
Outdated
@@ -31,7 +31,7 @@ Bug Fixes | |||
|
|||
Other | |||
--------------------- | |||
(No changes) | |||
* GITHUB#14081: Fix urls describing why NIOFS is not recommended for Windows (Marcel Yeonghyeon Ko) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include this patch in Lucene 10.2.0 :)
(Merge into the main -> cherry-pick to the branch_10x)
Lucene 11 is a long way from being released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danmuzi Thanks for reviewing my PR. I fixed CHANGES.txt to include in Lucene 10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@danmuzi I appreciate your review. Let me know any remaining steps I need to take before merging this PR. |
This patch has been merged. I’ll cherry-pick it into branch_10x. |
This patch fixes incorrect URL links in NIOFSDirectory and FSDirectory.
Description