Skip to content

Commit

Permalink
Fix urls describing why NIOFS is not recommended for Windows (#14081)
Browse files Browse the repository at this point in the history
This patch fixes incorrect URL links in NIOFSDirectory and FSDirectory.
  • Loading branch information
YeonghyeonKO authored and danmuzi committed Jan 9, 2025
1 parent 18c187b commit 4899e7d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lucene/CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Bug Fixes

Other
---------------------
(No changes)
* GITHUB#14081: Fix urls describing why NIOFS is not recommended for Windows (Marcel Yeonghyeon Ko)

======================= Lucene 10.1.0 =======================

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
* post</a>.
* <li>{@link NIOFSDirectory} uses java.nio's FileChannel's positional io when reading to avoid
* synchronization when reading from the same file. Unfortunately, due to a Windows-only <a
* href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734">Sun JRE bug</a> this is a
* href="https://bugs.java.com/bugdatabase/view_bug?bug_id=6265734">Sun JRE bug</a> this is a
* poor choice for Windows, but on all other platforms this is the preferred choice.
* Applications using {@link Thread#interrupt()} or {@link Future#cancel(boolean)} should use
* {@code RAFDirectory} instead, which is provided in the {@code misc} module. See {@link
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* <p><b>NOTE</b>: NIOFSDirectory is not recommended on Windows because of a bug in how
* FileChannel.read is implemented in Sun's JRE. Inside of the implementation the position is
* apparently synchronized. See <a
* href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734">here</a> for details.
* href="https://bugs.java.com/bugdatabase/view_bug?bug_id=6265734">here</a> for details.
*
* <p><b>NOTE:</b> Accessing this class either directly or indirectly from a thread while it's
* interrupted can close the underlying file descriptor immediately if at the same time the thread
Expand Down

0 comments on commit 4899e7d

Please sign in to comment.