Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urls describing why NIOFS is not recommended for Windows #14081

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix urls describing why NIOFS is not recommended for Windows #14081

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0d84b4
Update the link in FSDirectory.java (JRE bug of NIOFS in Windows)
YeonghyeonKO Dec 19, 2024
b4b713a
Update the link in NIOFSDirectory.java (JRE bug of NIOFS in Windows)
YeonghyeonKO Dec 19, 2024
4143049
Update CHANGES.txt
YeonghyeonKO Dec 19, 2024
387b46e
include #14081 PR to lucene 10.x
YeonghyeonKO Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Bug Fixes

Other
---------------------
(No changes)
* GITHUB#14081: Fix urls describing why NIOFS is not recommended for Windows (Marcel Yeonghyeon Ko)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this patch in Lucene 10.2.0 :)
(Merge into the main -> cherry-pick to the branch_10x)
Lucene 11 is a long way from being released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmuzi Thanks for reviewing my PR. I fixed CHANGES.txt to include in Lucene 10.2


======================= Lucene 10.2.0 =======================

Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/store/FSDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
* post</a>.
* <li>{@link NIOFSDirectory} uses java.nio's FileChannel's positional io when reading to avoid
* synchronization when reading from the same file. Unfortunately, due to a Windows-only <a
* href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734">Sun JRE bug</a> this is a
* href="https://bugs.java.com/bugdatabase/view_bug?bug_id=6265734">Sun JRE bug</a> this is a
* poor choice for Windows, but on all other platforms this is the preferred choice.
* Applications using {@link Thread#interrupt()} or {@link Future#cancel(boolean)} should use
* {@code RAFDirectory} instead, which is provided in the {@code misc} module. See {@link
Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/store/NIOFSDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* <p><b>NOTE</b>: NIOFSDirectory is not recommended on Windows because of a bug in how
* FileChannel.read is implemented in Sun's JRE. Inside of the implementation the position is
* apparently synchronized. See <a
* href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734">here</a> for details.
* href="https://bugs.java.com/bugdatabase/view_bug?bug_id=6265734">here</a> for details.
*
* <p><b>NOTE:</b> Accessing this class either directly or indirectly from a thread while it's
* interrupted can close the underlying file descriptor immediately if at the same time the thread
Expand Down
Loading