Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26707: Reduce number of renames during bulkload (#4066) #4122

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

BukrosSzabolcs
Copy link
Contributor

move files directly to the store dir when requireWritingToTmpDirFirst is false
fix failedBulkLoad to work on second call
change existing tests to run without tmp folder too
add tests for SecureBulkLoadListener

@BukrosSzabolcs
Copy link
Contributor Author

Hi @wchevreuil created the branch-2 PR as requested

@wchevreuil
Copy link
Contributor

recheck

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 3m 19s branch-2 passed
+1 💚 compile 2m 42s branch-2 passed
+1 💚 checkstyle 1m 0s branch-2 passed
+1 💚 spotbugs 2m 5s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 compile 2m 39s the patch passed
-0 ⚠️ javac 0m 30s hbase-it generated 5 new + 98 unchanged - 5 fixed = 103 total (was 103)
-0 ⚠️ checkstyle 0m 43s hbase-server: The patch generated 24 new + 217 unchanged - 0 fixed = 241 total (was 217)
-0 ⚠️ checkstyle 0m 9s hbase-it: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 8m 23s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 1m 59s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
33m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4122
JIRA Issue HBASE-26707
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 4bdf92e2b077 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b9b7a65
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count 60 (vs. ulimit of 12500)
modules C: hbase-server hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 27s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 46s branch-2 passed
+1 💚 compile 1m 19s branch-2 passed
+1 💚 shadedjars 4m 48s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 35s the patch passed
+1 💚 compile 1m 12s the patch passed
+1 💚 javac 1m 12s the patch passed
+1 💚 shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s the patch passed
_ Other Tests _
+1 💚 unit 337m 53s hbase-server in the patch passed.
+1 💚 unit 1m 12s hbase-it in the patch passed.
364m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4122
JIRA Issue HBASE-26707
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7fa31737b530 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b9b7a65
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/testReport/
Max. process+thread count 1931 (vs. ulimit of 12500)
modules C: hbase-server hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 45s branch-2 passed
+1 💚 compile 1m 10s branch-2 passed
+1 💚 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 36s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 shadedjars 4m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s the patch passed
_ Other Tests _
+1 💚 unit 359m 22s hbase-server in the patch passed.
+1 💚 unit 0m 58s hbase-it in the patch passed.
379m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4122
JIRA Issue HBASE-26707
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8eb9e5f864f9 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / b9b7a65
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/testReport/
Max. process+thread count 1942 (vs. ulimit of 12500)
modules C: hbase-server hbase-it U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4122/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit 77bb153 into apache:branch-2 Feb 25, 2022
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
…pache#4122)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
…pache#4122)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
…pache#4122)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
…pache#4122)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell added a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <[email protected]>
Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell pushed a commit that referenced this pull request Mar 26, 2022
Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java
apurtell added a commit that referenced this pull request Mar 26, 2022
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file #3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <[email protected]>
Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…pache#4122)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java

Change-Id: I7bc468b99b4641673e42a8fb0e887d6a6088d08e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants