HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache9
reviewed
Sep 27, 2021
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
|
OK, we have the same logic when migrating the rs group config... So let me see if we could have a more robust way, not your problem... |
|
🎊 +1 overall
This message was automatically generated. |
|
After thinking, I think here we'd better introduce a special procedure to do this, as store file tracker is more critical than rs group. The procedure will be similiar to ModifyTableProcedure, but it does not need to reopen all the regions. |
|
💔 -1 overall
This message was automatically generated. |
I will refacor this background thread later. Let me check whether the logic of SFT changes in other places also need to use procedure. |
|
🎊 +1 overall
This message was automatically generated. |
The typical way to change SFT is through ModifyTableProcedure... |
wchevreuil
reviewed
Sep 27, 2021
| } | ||
| }, "StoreFileTrackerChecking"); | ||
| STFChecking.setDaemon(true); | ||
| STFChecking.start(); |
There was a problem hiding this comment.
This may cause too many threads to be submitted at once during initialisation, on clusters with many tables. And could we have some sort of "rolling-upgrade" to be set that would trigger this code, instead of doing this within every master initialization? I guess even if we do refactor this to be run as procedures, it would be worth avoid unnecessary runs.
There was a problem hiding this comment.
Agree with you. Let me see if there is any way to solve it.
Yes, It relevant for upgrading different SFTs implementations. |
|
@Apache9 Thanks for your suggestion, I think we should introduce a SilentModifyTableProcedure to use the procedure framework to update tableDescriptor instead of updating tableDescriptor directly to avoid critical race and lead to data loss. I will upload the code for you to review later |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
GeorryHuang
force-pushed
the
HBASE-26263
branch
from
2addcdc to
9604a61
Compare
|
Please take a look. UTs will be pushed later |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 11, 2021
There was a problem hiding this comment.
In general I like the approach to introduce a chore for upgrading and also a new procedure for updating the procedure.
But the problem here is the inheritance hierarchy of the procedures. We have a lot of states for ModifyTableProcedure, which are not needed for the upgrading procedure, and also, it will be safer if we do the check on whether we still need to update the descriptor in the procedure.
So let me 'steal' part of your work here, to reimplement the migrating of rs group on master branch, and then do a rebase so you could make use of the code to implement this PR cleaner.
WDYT?
Thanks.
I agree with you. |
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
) Signed-off-by: Duo Zhang <[email protected]>
…g from different store file tracker implementations (apache#3656) Signed-off-by: Wellington Chevreuil <[email protected]>
…iptor when creating table (apache#3666) Signed-off-by: Duo Zhang <[email protected]>
… file tracker implementation (apache#3665) Signed-off-by: Wellington Chevreuil <[email protected]>
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Now checkstyle has been fixed, but UT failed. It seems to be related to replication, it should not be caused by my commit. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed UTs seems not related. Let me merge. |
Apache9
pushed a commit
that referenced
this pull request
Nov 6, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 9, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 27, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 6, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 17, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2021
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 1, 2022
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 4, 2022
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 18, 2022
…ations to TableDescriptor for existing tables (apache#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 19, 2022
…ations to TableDescriptor for existing tables (apache#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 25, 2022
…ations to TableDescriptor for existing tables (apache#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…ations to TableDescriptor for existing tables (apache#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
that referenced
this pull request
Mar 26, 2022
…ations to TableDescriptor for existing tables (#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
added a commit
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file #3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…ations to TableDescriptor for existing tables (apache#3700) Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]> Change-Id: I32214acc8704fd0a76c8f6c9001238890c1a8b3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ations to TableDescriptor for existing tables