Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 29, 2022

…4030)

Signed-off-by: Wellington Ramos Chevreuil [email protected]
Reviewed-by: Josh Elser [email protected]

@Apache9 Apache9 added the backport This PR is a back port of some issue or issues already committed to master label Jan 29, 2022
@Apache9 Apache9 self-assigned this Jan 29, 2022
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 11s branch-2 passed
+1 💚 compile 6m 45s branch-2 passed
+1 💚 checkstyle 2m 53s branch-2 passed
+1 💚 spotbugs 7m 48s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 6m 44s the patch passed
+1 💚 cc 6m 44s the patch passed
-0 ⚠️ javac 3m 24s hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚 checkstyle 0m 10s The patch passed checkstyle in hbase-protocol-shaded
-0 ⚠️ checkstyle 0m 37s hbase-client: The patch generated 1 new + 227 unchanged - 4 fixed = 228 total (was 231)
+1 💚 checkstyle 1m 19s hbase-server: The patch generated 0 new + 215 unchanged - 1 fixed = 215 total (was 216)
+1 💚 checkstyle 0m 45s The patch passed checkstyle in hbase-thrift
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 55s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 2m 26s the patch passed
+1 💚 spotbugs 8m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
71m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4080
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 84e1f605a404 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 76eb1b0
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 4m 35s branch-2 passed
+1 💚 compile 3m 16s branch-2 passed
+1 💚 shadedjars 7m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 18s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 4m 15s the patch passed
+1 💚 compile 3m 13s the patch passed
+1 💚 javac 3m 13s the patch passed
+1 💚 shadedjars 7m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 16s the patch passed
_ Other Tests _
+1 💚 unit 0m 54s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 1s hbase-client in the patch passed.
+1 💚 unit 136m 7s hbase-server in the patch passed.
+1 💚 unit 6m 21s hbase-thrift in the patch passed.
185m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4080
Optional Tests javac javadoc unit shadedjars compile
uname Linux ffbec46bf8ab 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 76eb1b0
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/testReport/
Max. process+thread count 4237 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s branch-2 passed
+1 💚 compile 2m 47s branch-2 passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 35s the patch passed
+1 💚 compile 2m 45s the patch passed
+1 💚 javac 2m 45s the patch passed
+1 💚 shadedjars 6m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s the patch passed
_ Other Tests _
+1 💚 unit 0m 46s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 44s hbase-client in the patch passed.
+1 💚 unit 154m 27s hbase-server in the patch passed.
+1 💚 unit 5m 54s hbase-thrift in the patch passed.
198m 40s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4080
Optional Tests javac javadoc unit shadedjars compile
uname Linux 412f6f128362 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 76eb1b0
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/testReport/
Max. process+thread count 3690 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s branch-2 passed
+1 💚 compile 6m 45s branch-2 passed
+1 💚 checkstyle 2m 50s branch-2 passed
+1 💚 spotbugs 7m 43s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 6m 41s the patch passed
+1 💚 cc 6m 41s the patch passed
-0 ⚠️ javac 3m 21s hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚 checkstyle 0m 9s The patch passed checkstyle in hbase-protocol-shaded
+1 💚 checkstyle 0m 37s hbase-client: The patch generated 0 new + 227 unchanged - 4 fixed = 227 total (was 231)
+1 💚 checkstyle 1m 17s hbase-server: The patch generated 0 new + 215 unchanged - 1 fixed = 215 total (was 216)
+1 💚 checkstyle 0m 45s The patch passed checkstyle in hbase-thrift
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 2m 28s the patch passed
+1 💚 spotbugs 8m 31s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
71m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4080
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 6192936c9d08 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 76eb1b0
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 30s branch-2 passed
+1 💚 compile 2m 46s branch-2 passed
+1 💚 shadedjars 6m 35s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 53s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 2m 45s the patch passed
+1 💚 javac 2m 45s the patch passed
+1 💚 shadedjars 6m 35s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 50s the patch passed
_ Other Tests _
+1 💚 unit 0m 42s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 48s hbase-client in the patch passed.
+1 💚 unit 153m 34s hbase-server in the patch passed.
+1 💚 unit 5m 55s hbase-thrift in the patch passed.
197m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4080
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3a24fd572ae1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 76eb1b0
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/testReport/
Max. process+thread count 3594 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4080/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit dffeb8e into apache:branch-2 Jan 30, 2022
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
apurtell added a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <[email protected]>
Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell pushed a commit that referenced this pull request Mar 26, 2022
apurtell added a commit that referenced this pull request Mar 26, 2022
…others) to branch-2.5

Previous cherry picks:

commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file #3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)

Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.

Signed-off-by: Josh Elser <[email protected]>
Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…pache#4030) (apache#4080)

Signed-off-by: Wellington Ramos Chevreuil <[email protected]>
Reviewed-by: Josh Elser <[email protected]>

Change-Id: I2668783c0903641ebef24d53d8e30018829735b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants