[ISSUE #3888]Optimize xml file License #3890

mxsm · 2023-05-08T15:39:41Z

Fixes #3888

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Optimize xml file License

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Update README.md

transfer dashboard

transfer project

transfer docs to eventmesh-site

transfer catalog from parent

transfer docs

…RuntimeException

[ISSUE apache#3545]Rename StorageConnectorRuntimeException to StorageRuntimeException

add redirect address for eventmesh-workflow

[fix] Fix CI issues

…MessageProcessor] Make this anonymous inner class a lambda

[ISSUE apache#3829]Do some code optimization.[CloudEventUtils]

[ISSUE#3821][Enhancement] Change this hard-coding.[WebhookFileListener]

…ets.UTF_8 (apache#3818) * fixes#3389 * Update EventMeshConstants.java * Update EventMeshConstants.java --------- Co-authored-by: mike_xwm <[email protected]>

…actored. (apache#3842) * Refactor HttpRequestProcessor and its subclasses. * Refactor HttpRequestProcessor's subclasses. * Fix checkstyle error. * Revoke controversial import static. * Fix compile error.

…)' (apache#3840) * Update MessageQueueTest.java Replaced `assertTrue()` with `assertEquals` at lines 106,111 * Update MessageQueueTest.java * Update MessageQueueTest.java

…nd related class (apache#3844) * Some Optimization * Fix checkstyle error. * Simplify code. * Revoke controversial import static.

…apache#3819) * Refacotr DelayRetryable and RetryContext. * Modify as review.

…hy. (apache#3847) * Remove the redundant method declaration and unused field. * Modify as review. * Modify access modifier.

…les and repetitive method def. (apache#3850) * many unused variables and repetitive method def. * modify wrong api usage. * Revoke controversial import static.

codecov · 2023-05-09T07:27:39Z

Codecov Report

Merging #3890 (70485dd) into master (e1e9aca) will not change coverage.
The diff coverage is n/a.

❗ Current head 70485dd differs from pull request most recent head 01c6426. Consider uploading reports for the commit 01c6426 to get more accurate results

@@            Coverage Diff            @@
##             master    #3890   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28847           
  Branches       2811     2811           
=========================================
  Hits           4019     4019           
  Misses        24455    24455           
  Partials        373      373

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

weihubeats · 2023-08-31T11:17:55Z

Conflict resolution, please.

Pil0tXia · 2024-01-19T08:53:11Z

eventmesh-examples/src/main/resources/log4j2.xml

+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with


The ~ should be removed, not just the ~, to maintain the correct two-space indentation.

The ~ should be removed, not just the ~, to maintain the correct two-space indentation.

I will do later

Most of log4j.xml files has been removed in #4719, and a checkstyle-header-xml.txt header file has been added in #4827.

It seems the xml header file with ~ included is the default header applied by apache/skywalking-eyes action. Do you think we still need to remove the ~ in the header?

@pchengma @mxsm We have an unresolved conversation here~ Please take a look.

I think both styles are OK. If ~ is auto-generated, it is fine to keep it. Nevertheless, some projects may not use ~ , for example fineract.

Yes, the apache/skywalking-eyes action is considered valid for both license headers with and without ~. However it adds ~ when auto-generating. Considering that all xml license headers in EventMesh now have ~, we can unify having ~.

github-actions · 2024-04-22T18:31:29Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

codecov-commenter · 2024-04-22T18:31:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.93%. Comparing base (e1e9aca) to head (70485dd).
Report is 502 commits behind head on master.

❗ Current head 70485dd differs from pull request most recent head 01c6426. Consider uploading reports for the commit 01c6426 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #3890   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28847           
  Branches       2811     2811           
=========================================
  Hits           4019     4019           
  Misses        24455    24455           
  Partials        373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pchengma

LGTM

pchengma · 2024-05-24T06:03:47Z

@mxsm Please fix conflicts.

github-actions · 2024-07-24T18:35:17Z

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

The merge-base changed after approval.

qqeasonchen and others added 30 commits March 28, 2023 17:32

Update README.md

53780e1

Merge pull request apache#3538 from apache/qqeasonchen-patch-23

5ee873f

Update README.md

transfer dashboard

755d8eb

Merge pull request apache#3539 from qqeasonchen/master

32ff608

transfer dashboard

transfer project

5a545c3

Merge pull request apache#3540 from qqeasonchen/master

a475eaf

transfer project

transfer docs to eventmesh-site

0092792

Merge branch 'apache:master' into master

205601b

Merge pull request apache#3541 from qqeasonchen/master

3b29339

transfer docs to eventmesh-site

transfer catalog from parent

2d7a116

transfer catalog from parent.

39756d4

Merge pull request apache#3542 from qqeasonchen/master

d73ecea

transfer catalog from parent

transfer docs

9cf60e3

Merge branch 'apache:master' into master

72706a2

Merge pull request apache#3543 from qqeasonchen/master

a1457f1

transfer docs

[ISSUE apache#3545]Rename StorageConnectorRuntimeException to Storage…

2f05230

…RuntimeException

Merge pull request apache#3546 from mxsm/eventmesh-3545

5c5f155

[ISSUE apache#3545]Rename StorageConnectorRuntimeException to StorageRuntimeException

fix CI issues

82f94a8

deprecate CI for event-mesh server go

f69411c

fix dependencies issue

d213efc

add redirect address for eventmesh-workflow

ab8a184

update

fed6965

Merge pull request apache#3549 from qqeasonchen/master

f185138

add redirect address for eventmesh-workflow

Merge pull request apache#3544 from hgaol/fix-ci-issues

e740ae9

[fix] Fix CI issues

fix json serialization issue when using redis

c4a0b6e

update for data type content

b800bdd

change data content type to lowercase and update buildEventMeshMessage

f899034

update

ef068df

update

6f1c280

Replace 'incubator-eventmesh' in the project with 'eventmesh'.

586372e

Sunstreaker and others added 14 commits May 5, 2023 10:37

[ISSUE apache#3407] Make this anonymous inner class a lambda[SendSync…

ef9e37c

…MessageProcessor] Make this anonymous inner class a lambda

Merge pull request apache#3860 from harshithasudhakar/patch-31

c620c33

[ISSUE apache#3829]Do some code optimization.[CloudEventUtils]

Merge pull request apache#3838 from nikam14/patch-20

f526004

[ISSUE#3821][Enhancement] Change this hard-coding.[WebhookFileListener]

[ISSUE apache#3389] Replace Charset.forName() call with StandardChars…

0074694

…ets.UTF_8 (apache#3818) * fixes#3389 * Update EventMeshConstants.java * Update EventMeshConstants.java --------- Co-authored-by: mike_xwm <[email protected]>

[ISSUE apache#3820]HttpRequestProcessor and its subclasses can be ref…

02b9448

…actored. (apache#3842) * Refactor HttpRequestProcessor and its subclasses. * Refactor HttpRequestProcessor's subclasses. * Fix checkstyle error. * Revoke controversial import static. * Fix compile error.

[ISSUE apache#3826]'assertTrue()' can be simplified to 'assertEquals(…

d976bbf

…)' (apache#3840) * Update MessageQueueTest.java Replaced `assertTrue()` with `assertEquals` at lines 106,111 * Update MessageQueueTest.java * Update MessageQueueTest.java

[ISSUE apache#3843]Simplify code in some subclasses of AbstractTask a…

b793959

…nd related class (apache#3844) * Some Optimization * Fix checkstyle error. * Simplify code. * Revoke controversial import static.

[ISSUE apache#3815]DelayRetryable and RetryContext can be refactored. (…

7f05cfb

…apache#3819) * Refacotr DelayRetryable and RetryContext. * Modify as review.

[ISSUE apache#3823]Math operands should be cast before assignment.

6a8a7f7

[ISSUE apache#3846]Remove the redundant method declaration in hierarc…

3686443

…hy. (apache#3847) * Remove the redundant method declaration and unused field. * Modify as review. * Modify access modifier.

[ISSUE apache#3831]Change this assertion to not compare two literals

d55288d

[ISSUE apache#3849]GrpcMessageProtocolResolver has many unused variab…

733d6ef

…les and repetitive method def. (apache#3850) * many unused variables and repetitive method def. * modify wrong api usage. * Revoke controversial import static.

[ISSUE apache#3835]Add final and @nonnull[EventMeshThreadFactory]

e1e9aca

[ISSUE apache#3888]Optimize xml file License

01c6426

Alonexc previously approved these changes May 12, 2023

View reviewed changes

Pil0tXia reviewed Jan 19, 2024

View reviewed changes

github-actions bot added the Stale label Apr 22, 2024

github-actions bot removed the Stale label Apr 23, 2024

pchengma previously approved these changes May 22, 2024

View reviewed changes

github-actions bot added the Stale label Jul 24, 2024

xwm1992 force-pushed the master branch from 4ea9f76 to e8fdcd3 Compare February 13, 2025 03:23

github-actions bot removed the Stale label Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #3888]Optimize xml file License #3890

[ISSUE #3888]Optimize xml file License #3890

mxsm commented May 8, 2023

codecov bot commented May 9, 2023 •

edited

Loading

weihubeats commented Aug 31, 2023

Pil0tXia Jan 19, 2024

mxsm Jan 19, 2024

Pil0tXia Apr 23, 2024

Pil0tXia May 24, 2024

pchengma May 25, 2024

Pil0tXia May 25, 2024

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024

pchengma left a comment

pchengma commented May 24, 2024

github-actions bot commented Jul 24, 2024

		Licensed to the Apache Software Foundation (ASF) under one or more
		contributor license agreements. See the NOTICE file distributed with

[ISSUE #3888]Optimize xml file License #3890

Are you sure you want to change the base?

[ISSUE #3888]Optimize xml file License #3890

Conversation

mxsm commented May 8, 2023

Motivation

Modifications

Documentation

codecov bot commented May 9, 2023 • edited Loading

Codecov Report

weihubeats commented Aug 31, 2023

Pil0tXia Jan 19, 2024

Choose a reason for hiding this comment

mxsm Jan 19, 2024

Choose a reason for hiding this comment

Pil0tXia Apr 23, 2024

Choose a reason for hiding this comment

Pil0tXia May 24, 2024

Choose a reason for hiding this comment

pchengma May 25, 2024

Choose a reason for hiding this comment

Pil0tXia May 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2024

codecov-commenter commented Apr 22, 2024

Codecov Report

pchengma left a comment

Choose a reason for hiding this comment

pchengma commented May 24, 2024

github-actions bot commented Jul 24, 2024

codecov bot commented May 9, 2023 •

edited

Loading