Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make this anonymous inner class a lambda[SendSyncMessageProcessor] #3407

Closed
1 of 2 tasks
Alonexc opened this issue Mar 10, 2023 · 2 comments · Fixed by #3716
Closed
1 of 2 tasks

[Enhancement] Make this anonymous inner class a lambda[SendSyncMessageProcessor] #3407

Alonexc opened this issue Mar 10, 2023 · 2 comments · Fixed by #3716
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Mar 10, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendSyncMessageProcessor.java line 260
analysis and explanation:
Before Java 8, the only way to partially support closures in Java was by using anonymous inner classes. But the syntax of anonymous classes may seem unwieldy and unclear.
With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.

Describe the solution you'd like

image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Mar 10, 2023
@Alonexc Alonexc mentioned this issue Mar 10, 2023
Open
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Mar 10, 2023
@Sunstreaker
Copy link
Contributor

Yes I am willing to submit a PR!

Sunstreaker added a commit to Sunstreaker/eventmesh that referenced this issue Apr 12, 2023
@Sunstreaker
[apache#3407]
4369433 
change the anonymous inner class to a   lambda function for readability
@Alonexc
Copy link
Contributor Author

Alonexc commented Apr 12, 2023

@Sunstreaker Welcome to your pr.

Sunstreaker added a commit to Sunstreaker/eventmesh that referenced this issue Apr 13, 2023
@Sunstreaker
apache#3407
09f7364 
Make this anonymous inner class a lambda[
@Sunstreaker Sunstreaker mentioned this issue Apr 13, 2023
Merged
xwm1992 pushed a commit that referenced this issue May 5, 2023
@Sunstreaker
[ISSUE #3407] Make this anonymous inner class a lambda[SendSyncMessag…
ef9e37c 
…eProcessor]

Make this anonymous inner class a lambda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
3 participants
@Sunstreaker @xwm1992 @Alonexc