Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor datafusion python lit function to allow different types #1130

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Oct 16, 2021

Which issue does this PR close?

refactor datafusion lit function to allow different types

Closes #1131

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist force-pushed the python-refactor-lit branch from f8f0143 to 6c70f15 Compare October 16, 2021 09:53
@jimexist jimexist changed the title refactor datafusion lit function to allow different types refactor datafusion python lit function to allow different types Oct 16, 2021
@jimexist jimexist requested review from alamb and houqp October 16, 2021 10:13
@alamb
Copy link
Contributor

alamb commented Oct 16, 2021

This looks cool -- thank you I'll plan to review it tomorrow

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add boolean type too?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too -- bool is a good suggestion from @houqp

Another good set might be timestamps (datetime.date, etc) but perhaps we can add those as a separate PR

(nice tests, btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datafusion python function lit only accepts i32 values
3 participants