[python] add digest python function #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Oct 16, 2021
jimexist
force-pushed
the
add-digest-python-fun
branch
from
9b61a37 to
2185a39
Compare
houqp
reviewed
Oct 16, 2021
| @@ -49,7 +49,7 @@ jobs: | |||
| - name: Run Linters | |||
| run: | | |||
| source venv/bin/activate | |||
| flake8 python | |||
| flake8 python --ignore=E501 | |||
There was a problem hiding this comment.
how about adding this to setup.cfg so it's applied in all scenarios including local development runs?
There was a problem hiding this comment.
i'd defer that to later until more options are used
jimexist
force-pushed
the
add-digest-python-fun
branch
from
5a46a1a to
927ae16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1132
Should be merged after #1130
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?