Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support json_object('k':'v') in postgres #1546

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Nov 24, 2024

This just updates the postgres dialect definition to add support for the json_object syntax added in #1507

The syntax was initially added for mssql but also works in postgres

See https://www.postgresql.org/docs/current/functions-json.html

See #1545

support for json_object('k' VALUE 'v') is implemented in a separate PR

This just updates the postgres dialect definition to add support for the json_object syntax added in apache#1507

The syntax was initially added for mssql but also works in postgres

See https://www.postgresql.org/docs/current/functions-json.html

See apache#1545
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 24, 2024

I moved the corresponding tests from tests/sqlparser_mssql.rs to tests/sqlparser_common.rs

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lovasoa

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit 525d178 into apache:main Nov 25, 2024
8 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 25, 2024

🚀 -- thanks again

@lovasoa lovasoa deleted the postgres_json_object_with_colon branch November 25, 2024 21:36
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 25, 2024

Great ! #1547 should now be mergeable upon rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants