-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSSQL's JSON_ARRAY
/JSON_OBJECT
expr
#1507
Conversation
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
I modified existing DECLARE @id_key nvarchar(10) = N'id',@id_value nvarchar(64) = NEWID();
SELECT JSON_OBJECT(LOWER('USER_NAME') : USER_NAME(), LOWER(@id_key) : @id_value, 'sid':(SELECT @@SPID)); Break change: pub enum FunctionArg {
Named {
name: Expr, // <<
arg: FunctionArgExpr,
operator: FunctionArgOperator,
},
Unnamed(FunctionArgExpr),
} Please take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gaoqiangz I think this is looking good! Left some comments
I refactored function parameter list parsing,add some |
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
Thanks again @gaoqiangz and @iffyio and @lovasoa |
This just updates the postgres dialect definition to add support for the json_object syntax added in apache#1507 The syntax was initially added for mssql but also works in postgres See https://www.postgresql.org/docs/current/functions-json.html See apache#1545
I opened a new PR to enable this syntax in postgres, which supports it too: #1546 |
Solves #1506