test: parametrize test_array_functions #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
force-pushed
the
parametrize-array-function-tests
branch
from
e6bcab2 to
d71c436
Compare
Michael-J-Ward
force-pushed
the
parametrize-array-function-tests
branch
from
6745313 to
b872135
Compare
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670). test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input. test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases. Ref apache#671
Michael-J-Ward
force-pushed
the
parametrize-array-function-tests
branch
from
b872135 to
85a703e
Compare
timsaucer
approved these changes
May 17, 2024
|
@andygrove could we merge this? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #671
Rationale for this change
All of the tests in
test_functions.pyare overloaded - representing many more than one test case.What changes are included in this PR?
This cleans up
test_array_functions, which becomes 62 different test cases.test_array_functions now has 56 passing test cases and 1 expected failure (
array_slicebeing the expected failure Ref #670).test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.
test_array_function_obj_tests had a different set of asserts, so was broken out for 4 test cases.
Are there any user-facing changes?
No