Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate upstream array_slice fixes #670

Closed
2 of 4 tasks
Tracked by #727
Michael-J-Ward opened this issue May 8, 2024 · 0 comments · Fixed by #728
Closed
2 of 4 tasks
Tracked by #727

Incorporate upstream array_slice fixes #670

Michael-J-Ward opened this issue May 8, 2024 · 0 comments · Fixed by #728
Labels
bug Something isn't working

Comments

@Michael-J-Ward
Copy link
Contributor

Michael-J-Ward commented May 8, 2024 •
edited
Loading

Describe the bug
Upgrading in #669 discovered a few bugs in datafusion

Blocked on

So we commented out a single failing test to make the tests pass.
eeccbfd

TODO

Once the upstream fixes are available

  • re-introduce the test
  • (maybe?) provide a nullable default for stride in functions::array_slice
@Michael-J-Ward Michael-J-Ward added the bug Something isn't working label May 8, 2024
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 10, 2024
@Michael-J-Ward
docs: remove regexp_replace example
4bc1781 
This is the same underlying issue as apache#670. The new datafusion UDF functions don't properly handle optional arguments.
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 10, 2024
@Michael-J-Ward
docs: remove regexp_replace example
d0d3e36 
This is the same underlying issue as apache#670. The new datafusion UDF functions don't properly handle optional arguments.
@Michael-J-Ward Michael-J-Ward mentioned this issue May 10, 2024
Closed
1 task
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 11, 2024
@Michael-J-Ward
test: parametrize test_array_functions
251c010 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 11, 2024
@Michael-J-Ward
test: parametrize test_array_functions
e6bcab2 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
@Michael-J-Ward Michael-J-Ward mentioned this issue May 11, 2024
Merged
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 13, 2024
@Michael-J-Ward
test: parametrize test_array_functions
6745313 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 15, 2024
@Michael-J-Ward
test: parametrize test_array_functions
b872135 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 15, 2024
@Michael-J-Ward
test: parametrize test_array_functions
85a703e 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
andygrove pushed a commit that referenced this issue May 23, 2024
@Michael-J-Ward
test: parametrize test_array_functions (#678)
e029559 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref #670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref #671
@Michael-J-Ward Michael-J-Ward mentioned this issue Jun 12, 2024
Closed
8 tasks
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Jun 13, 2024
@Michael-J-Ward
feat: incorporate upstream array_slice fixes
f7b24df 
Fixes apache#670
@Michael-J-Ward Michael-J-Ward mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade datafusion 39 Michael-J-Ward/datafusion-python
1 participant
@Michael-J-Ward