Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest parametrize the array tests in test_functions.py #671

Closed
2 tasks done
Michael-J-Ward opened this issue May 8, 2024 · 2 comments
Closed
2 tasks done

pytest parametrize the array tests in test_functions.py #671

Michael-J-Ward opened this issue May 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Michael-J-Ward
Copy link
Contributor

Michael-J-Ward commented May 8, 2024 •
edited
Loading

Describe the solution you'd like
Each UDF in src/functions.py should have its own test case in test_functions.py instead of testeing a bunch of functions in a single test case.

TODO

  • pytest.mark.parameterize the functions
  • ensure that every function in src/functions.rs has a test case
@Michael-J-Ward Michael-J-Ward added the enhancement New feature or request label May 8, 2024
@Michael-J-Ward Michael-J-Ward changed the title pytest parameterize the tests in test_functions.py pytest parametrize the tests in test_functions.py May 11, 2024
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 11, 2024
@Michael-J-Ward
test: parametrize test_array_functions
251c010 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 11, 2024
@Michael-J-Ward
test: parametrize test_array_functions
e6bcab2 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
@Michael-J-Ward Michael-J-Ward mentioned this issue May 11, 2024
Merged
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 13, 2024
@Michael-J-Ward
test: parametrize test_array_functions
6745313 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 15, 2024
@Michael-J-Ward
test: parametrize test_array_functions
b872135 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue May 15, 2024
@Michael-J-Ward
test: parametrize test_array_functions
85a703e 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref apache#670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref apache#671
andygrove pushed a commit that referenced this issue May 23, 2024
@Michael-J-Ward
test: parametrize test_array_functions (#678)
e029559 
test_array_functions now has 56 passing test cases and 1 expected failure (`array_slice` being the expected failure Ref #670).

test_array_function_flatten was broken out as a single test because it was an outlier in terms of test-input.

test_array_function_obj_tests had a different set of asserts, so was broken out for 5 test cases.

Ref #671
@raulcd
Copy link
Member

raulcd commented Jun 18, 2024

Is this supposed to be closed due to #678 being merged?

@Michael-J-Ward Michael-J-Ward changed the title pytest parametrize the tests in test_functions.py pytest parametrize the array tests in test_functions.py Jun 18, 2024
@Michael-J-Ward
Copy link
Contributor Author

Gracias. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raulcd @Michael-J-Ward