Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE; currently testing] standardizing GCSIO batch responses #27364

Closed
wants to merge 8 commits into from

Conversation

BjornPrime
Copy link
Contributor

fixes #27325.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #27364 (bdb9e64) into master (1842dd2) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #27364      +/-   ##
==========================================
- Coverage   71.23%   71.05%   -0.19%     
==========================================
  Files         854      858       +4     
  Lines      103713   104088     +375     
==========================================
+ Hits        73885    73963      +78     
- Misses      28280    28577     +297     
  Partials     1548     1548              
Flag Coverage Δ
python 80.25% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/gcsio.py 65.78% <0.00%> (-0.88%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 77.16% <0.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Changes incorporated into new GCSIO client swap PR #27471

@BjornPrime BjornPrime closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Standardize GCSIO batch methods responses
2 participants