Replace StorageV1 client with GCS client (take 2) #27471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BjornPrime
changed the title
|
Run Python 3.11 PostCommit |
3 tasks
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
BjornPrime
force-pushed
the
replace-storage-client
branch
from
7b8c58b to
582b162
Compare
…" (apache#27388)" This reverts commit 7ce2d00.
|
Run Python 3.11 PostCommit |
* Fix broken url for 'Tour of Beam' * Update examples/notebooks/get-started/learn_beam_basics_by_doing.ipynb Co-authored-by: Danny McCormick <[email protected]> * Fix unrelated diff --------- Co-authored-by: Danny McCormick <[email protected]>
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](golang/oauth2@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
author Bjorn Pedersen <[email protected]> 1688152191 -0400 committer Bjorn Pedersen <[email protected]> 1691418620 -0400 Replace StorageV1 client with GCS client first attempt at standardizing responses tinkering to get a better error message trying out appending the response tuples defining success response codes more broadly fixed re-delete behavior added assertions checking that request and response lengths are equal changed delete_blobs to delete_blob fix apiclient bug making juliaset work size smaller to see if it is actually timing out apiclient debugging removed test_user_agent_insert_all tinkering with apiclient replacing return value commenting out set-up file restoring setup file to see if that induces test failure Revert "restoring setup file to see if that induces test failure" This reverts commit c0af90c. Revert "Revert "restoring setup file to see if that induces test failure"" This reverts commit a339f4c. enabled raw_download for uncompressed files fixing unit tests set raw_download to always be true commented out setup_file again Revert "commented out setup_file again" This reverts commit 157311e. reverting raw_download implementation gcs filesystem no longer forces mime_type to match compression updated stage_file to use BlobWriter directly, rather than go through FileSystem corrected BlobWriter import restoring gcsio batch response work Revert "making juliaset work size smaller to see if it is actually timing out" This reverts commit 582b162. Revert "gcs filesystem no longer forces mime_type to match compression" This reverts commit c04ed94.
github-actions
bot
added
java
go
build
docker
vendor
extensions
runners
dataflow
kryo
and removed
java
go
build
docker
vendor
extensions
runners
dataflow
kryo
labels
|
Ran into some issues with rogue commits to this branch. Updated version (using new branch) at #27878. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25676.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.