Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Standardize GCSIO batch methods responses #27325

Closed
1 of 15 tasks
BjornPrime opened this issue Jun 30, 2023 · 3 comments
Closed
1 of 15 tasks

[Task]: Standardize GCSIO batch methods responses #27325

BjornPrime opened this issue Jun 30, 2023 · 3 comments

Comments

@BjornPrime
Copy link
Contributor

What needs to happen?

In the upgrade from an apitools-based client GCSIO's batch methods needed to use the new GCS client Batch objects, which reported their responses differently from what Beam tends to expect. Transform the batch._responses field that they're currently returning into a tuple of the form (path, exception) for delete_batch and (src, dest, exception) for copy_batch. Then fix their usage in gcsfilesystem.py so that paths with be passed along with their exceptions, like the other methods in that file.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@BjornPrime
Copy link
Contributor Author

.take-issue

@lostluck
Copy link
Contributor

lostluck commented Aug 2, 2023

2.50 release manager here.
This issue is currently tagged for the 2.50.0 release, which cuts in a week on August 9th.

Please complete work and get it into the main branch in that time, or move this issue to the 2.51 Milestone: https://github.com/apache/beam/milestone/15

@Abacn
Copy link
Contributor

Abacn commented Aug 3, 2023

This was obsolete. Original change reverted on master

@Abacn Abacn closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants