Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Failed test marked with no_xdist passes github action python test #17649

Closed
wants to merge 1 commit into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 12, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 12, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 12, 2022

Can one of the admins verify this patch?

@Abacn
Copy link
Contributor Author

Abacn commented May 12, 2022

CC: @AnandInguva this would block the current approach of #17569

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #17649 (175ab77) into master (d5df315) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17649      +/-   ##
==========================================
+ Coverage   73.95%   73.97%   +0.01%     
==========================================
  Files         693      693              
  Lines       91721    91724       +3     
==========================================
+ Hits        67834    67849      +15     
+ Misses      22638    22626      -12     
  Partials     1249     1249              
Flag Coverage Δ
python 83.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 77.53% <0.00%> (-2.18%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.46% <0.00%> (-0.64%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.55% <0.00%> (+0.12%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 91.72% <0.00%> (+0.75%) ⬆️
sdks/python/apache_beam/io/gcp/bigquery.py 65.10% <0.00%> (+1.12%) ⬆️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 84.34% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5df315...175ab77. Read the comment docs.

@Abacn
Copy link
Contributor Author

Abacn commented May 17, 2022

Fixed in #17687

@Abacn Abacn closed this May 17, 2022
@Abacn Abacn deleted the failuretest branch May 18, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants