Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14467] Fix bug where run_pytest.sh does not elevate errors raised in no_xdist tests #17687

Merged
merged 1 commit into from
May 17, 2022

Conversation

TheNeuralBit
Copy link
Member

@TheNeuralBit TheNeuralBit commented May 16, 2022

Verified this in #17685, see https://github.com/apache/beam/actions/runs/2335085262

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @Abacn

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #17687 (a5f3f3f) into master (03c3c36) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17687      +/-   ##
==========================================
- Coverage   74.00%   74.00%   -0.01%     
==========================================
  Files         695      695              
  Lines       91798    91798              
==========================================
- Hits        67939    67936       -3     
- Misses      22611    22614       +3     
  Partials     1248     1248              
Flag Coverage Δ
python 83.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/gcp/auth.py 73.33% <0.00%> (-5.34%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.80% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 88.13% <0.00%> (+0.56%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 91.72% <0.00%> (+0.75%) ⬆️
sdks/python/apache_beam/coders/typecoders.py 93.67% <0.00%> (+1.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c3c36...a5f3f3f. Read the comment docs.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0 is True in shell, what a mess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants