Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14367]Flaky timeout in StatefulDoFnOnDirectRunnerTest.test_dynamic_timer_clear_then_set_timer #17569

Merged
merged 1 commit into from
May 23, 2022

Conversation

AnandInguva
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 6, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 6, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the python label May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #17569 (6131924) into master (0daef62) will increase coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17569      +/-   ##
==========================================
+ Coverage   73.86%   74.34%   +0.48%     
==========================================
  Files         690      694       +4     
  Lines       91031    94070    +3039     
==========================================
+ Hits        67236    69938    +2702     
- Misses      22575    22912     +337     
  Partials     1220     1220              
Flag Coverage Δ
python 83.93% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache_beam/runners/dataflow/test_dataflow_runner.py 28.12% <0.00%> (-4.53%) ⬇️
sdks/python/apache_beam/coders/row_coder.py 94.49% <0.00%> (-2.51%) ⬇️
sdks/python/apache_beam/runners/common.py 87.94% <0.00%> (-2.33%) ⬇️
...ache_beam/runners/interactive/recording_manager.py 96.03% <0.00%> (-0.56%) ⬇️
...ks/python/apache_beam/runners/interactive/utils.py 95.15% <0.00%> (-0.26%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.55% <0.00%> (-0.09%) ⬇️
setup.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/api.py 90.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/base.py 92.53% <0.00%> (ø)
sdks/python/apache_beam/portability/common_urns.py 100.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daef62...6131924. Read the comment docs.

@Abacn
Copy link
Contributor

Abacn commented May 6, 2022

Does this indicate the tested object is not thread safe or any indication of defect on the sdk side, or is the test being flaky caused by the issue of the test itself?

@AnandInguva
Copy link
Contributor Author

Does this indicate the tested object is not thread safe or any indication of defect on the sdk side, or is the test being flaky caused by the issue of the test itself?

We suspect the timeout happens because the tests are run in parallel and may be resources are used more. So, running this test case using no_xdist might solve the flakiness.

@AnandInguva
Copy link
Contributor Author

R: @tvalentyn

@AnandInguva
Copy link
Contributor Author

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants