Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12399][cherry-pick] Move CPython license to own file. (#15201) #15211

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

angoenka
Copy link
Contributor

  • [BEAM-12399] Move CPython license to own file.
  • [BEAM-12399] Add LICENSE.python to python MANIFEST
  • [BEAM-12399] Filter LICENSE.python from RAT check.
  • [BEAM-12399] Refer to file by proximity rather than URL.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

* [BEAM-12399] Move CPython license to own file.
* [BEAM-12399] Add LICENSE.python to python MANIFEST
* [BEAM-12399] Filter LICENSE.python from RAT check.
* [BEAM-12399] Refer to file by proximity rather than URL.
@angoenka angoenka requested a review from lostluck July 23, 2021 19:14
@angoenka angoenka changed the title [BEAM-12399] Move CPython license to own file. (#15201) [BEAM-12399][cherry-pick] Move CPython license to own file. (#15201) Jul 23, 2021
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-2.32.0@87d0050). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.32.0   #15211   +/-   ##
=================================================
  Coverage                  ?   83.82%           
=================================================
  Files                     ?      441           
  Lines                     ?    59711           
  Branches                  ?        0           
=================================================
  Hits                      ?    50050           
  Misses                    ?     9661           
  Partials                  ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d0050...f8f777a. Read the comment docs.

@lostluck
Copy link
Contributor

Run GoPortable PreCommit

@lostluck
Copy link
Contributor

Run Go PostCommit

@lostluck
Copy link
Contributor

I believe the failures are not related to this PR so we could merge this. OR we can do a cherry pick of #15215 first, so this one can be merged clean.

Either way, this PR LGTM

@angoenka
Copy link
Contributor Author

The failure seems to be unrelated.

@angoenka angoenka merged commit ca866af into apache:release-2.32.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants