-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12656] Fix go-licenses build #15215
Conversation
R: @alanmyrvold |
Codecov Report
@@ Coverage Diff @@
## master #15215 +/- ##
==========================================
- Coverage 83.82% 83.82% -0.01%
==========================================
Files 441 441
Lines 59711 59706 -5
==========================================
- Hits 50053 50047 -6
- Misses 9658 9659 +1
Continue to review full report at Codecov.
|
Monday morning ping. |
LGTM |
(cherry picked from commit 1117f7d)
(cherry picked from commit 1117f7d)
Update the go-license container to use go 1.16 instead of go 1.15. Some of go-licenses deps have moved to using the go 1.16 embed and io/fs packages, breaking the rule.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.