-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12399] Move CPython license to own file. #15201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaltay
reviewed
Jul 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #15201 +/- ##
==========================================
- Coverage 83.82% 83.81% -0.02%
==========================================
Files 441 441
Lines 59706 59706
==========================================
- Hits 50051 50044 -7
- Misses 9655 9662 +7
Continue to review full report at Codecov.
|
R: @aaltay |
Run Java PreCommit |
Run Java_Examples_Dataflow PreCommit |
aaltay
approved these changes
Jul 23, 2021
angoenka
pushed a commit
to angoenka/beam
that referenced
this pull request
Jul 23, 2021
* [BEAM-12399] Move CPython license to own file. * [BEAM-12399] Add LICENSE.python to python MANIFEST * [BEAM-12399] Filter LICENSE.python from RAT check. * [BEAM-12399] Refer to file by proximity rather than URL.
angoenka
added a commit
that referenced
this pull request
Jul 28, 2021
* [BEAM-12399] Move CPython license to own file. * [BEAM-12399] Add LICENSE.python to python MANIFEST * [BEAM-12399] Filter LICENSE.python from RAT check. * [BEAM-12399] Refer to file by proximity rather than URL. Co-authored-by: Robert Burke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve BEAM-12399 (Beam Go SDK docs can't be displayed on the standard GoDoc site pkg.go.dev) we need to separate out the CPython license stack from the other licenses which apply more broadly.
Per golang/go#45095, and #46291 the issue is that the license not particularly compatible, so adding it as a recognized license is apparently not the way forward. However, as the license only needs to be posted with distributions of cpython, it largely only needs to go into the Python SDK container(s).
Since pkg.go.dev must be conservative about what it checks for LICENSE we can't pare down or filter what the site picks up (eg. a LICENSE.golang or a LICENSE in the sdks/go subdirectory file would only be added to whats in the root LICENSE, not supercede it). However, pkg.go.dev doesn't look at other LICENSE files for particular languages, hence the new file.
The way we're referring to the LICENSE.python sidecar file is also acceptable to Apache Legal https://issues.apache.org/jira/browse/LEGAL-582
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.