WIP: [R] Verify CRAN release-15.0.1 #40414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Rationale for this change The geoarrow repo was moved and is no failing urlcheck. ### What changes are included in this PR? Update the url. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…v version (#39524) ### Rationale for this change The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this. ### What changes are included in this PR? Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`. ### Are these changes tested? CI ### Are there any user-facing changes? No * Closes: #39523 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
I noticed a few docs that needed cleaning up when running make commands Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
### What changes are included in this PR? Update NEWS.md with things not included in 14.0.2. * Closes: #39626 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
### Rationale for this change CRAN. ### What changes are included in this PR? See the commit messages ### Are these changes tested? Existing CI should pass and not be affected. We should confirm that source builds get all features enabled. We should test on macbuilder with this package and with one where we've inserted `download.file <- function(...) stop()` at the top of nixlibs.R to simulate offline behavior. ### Are there any user-facing changes? I hope there is only one user affected. * Closes: #39697 Authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…tation from 2018 (#39750) ### Rationale for this change The godoc format shows docs in a versioned fashion, making the ["basic" link](https://pkg.go.dev/github.com/apache/arrow/go) reference v0.0.0 from 2018, and godoc doesn't warn you when docs are outdated. Accordingly, for people to find "real" documentation, they have to manually search for the latest docs. Otherwise, it gives the impression that the package is abandoned / makes devs waste considerable time — e.g., I work with Go professionally and wasted 15 minutes on the 2018 docs until I realized they were wrong. ### What changes are included in this PR? * Reference the latest version (v16) in the list of supported implementations of the Arrow website & R package. * Add step to release process that automatically updates the version on release ### Are these changes tested? Yes, I've added tests for this to `dev/release/post-11-bump-versions-test.rb`. ### Are there any user-facing changes? Yes, the link to Implementations > Go on the website will change. * Closes: #39761 Authored-by: Gabriel Tomitsuka <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: #39859 Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>
…of Arrow (#39739) ### Rationale for this change Development velocity of the R package has slowed considerably since early versions of Arrow such that the commit-level integration that we once relied on is no longer necessary. The ability to build against older versions of Arrow also opens up more options for our CRAN submissions, since we may be able to work with CRAN to build a version of Arrow C++ they are happy with. This change doesn't require us to *do* anything about it...it just adds a check so that we are aware of the first PR that breaks the ability to build against a previous version. There is a possibility that an accidentally but previously installed version will end up being used via pkg-config, which I believe is how the version checking came into existence in the first place. ### What changes are included in this PR? - An `#if` to guard code that was added to support the string view/binary view - Changes to the version checker script to not error for supported Arrow C++ versions - CI job that checks build against supported Arrow versions ### Are these changes tested? Yes, a CI job was added ### Are there any user-facing changes? Yes, but I'll wait until there's consensus on this before documenting what our intended support policy will be. * Closes: #39738 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
This ports some news entries written for the CRAN branch into main. * GitHub Issue: #40190 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
I'm not sure why this worked before, but 2.5.0 got a little stricter and now warns about this minor infelicity. I _think_ this is the only issue with 2.5.0, but if there's any way you could run your CI checks with dev dbplyr I'd really appreciate it! * GitHub Issue: #40199 Authored-by: Hadley Wickham <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
…chunksize (#40251) ### Rationale for this change A user [ran into confusion](https://lists.apache.org/thread/8ym8r1z5gys7dpcr8rw8dvjbkqc2lf7f) over the units of the `max_chunksize` argument in PyArrow and didn't see any reason not to make the documentation more explicit. ### What changes are included in this PR? Just changes to docstrings. ### Are these changes tested? No, though I did go through every change to see if it was correct and I'm pretty sure it's right. Good to double-check during review though. ### Are there any user-facing changes? Just docs. Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
thisisnic
requested review from
assignUser,
kou,
raulcd,
paleolimbot and
lidavidm
as code owners
|
@github-actions crossbow submit --group r |
|
38 tasks
|
@github-actions crossbow submit --group r |
|
Revision: ac97076 Submitted crossbow builds: ursacomputing/crossbow @ actions-2666d11abf
|
|
I don't know what to make from this one: https://github.com/ursacomputing/crossbow/actions/runs/8198491573/job/22422094029#step:9:39 |
|
I think many of these are related to #40323 |
Agreed. I don't see anything here which blocks the release. Not sure about the reason for devdocs failing though it seems to happen every release for some reason or another, but given other builds pass it's a non-issue. |
|
The revdep output below! The main difference (in dataverifyr) was because I had the local version built with extra error context. The bigquerystorage install failure has something to do with grpc (maybe bundled vs. homebrew source). The version of Arrow I'm using for 15.0.0 is the Python CMake preset so it has grpc built in. The adbi failure is because I was refactoring nanoarrow while building the checks. I can check that again but wanted to post these as soon as I had them. ChangesadbiWith CRAN arrowWith local arrowbigrquerystorageWith CRAN arrowWith local arrowdataverifyrWith CRAN arrowWith local arrowduckdbWith CRAN arrowWith local arrowsparklyrWith CRAN arrowWith local arrowCheck SummaryCRANLocalAll notes and errorsadbibigrquerystoragedataverifyrreceptivitiAndromedaAPCalignduckdbepiCleanrOlinkAnalyzepointblankRaMSsparklyrstrandtiledb |
|
All looks good and package on CRAN now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge - for release testing purposes only