-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39987: [R] Make it possible to use a rtools libarrow on windows #39986
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit r-binary-packages |
Revision: f405c66 Submitted crossbow builds: ursacomputing/crossbow @ actions-e8f1c270de
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I missing it, but where do we download from rwlinlib (specifically, https://github.com/rwinlib/arrow/archive/refs/tags/v13.0.0.zip right?)
# pkg-config --libs libcurl | ||
GCS_LIBS="-lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto -lcrypt32 -lwldap32 \ | ||
-lz -lws2_32 -lnghttp2 -ldbghelp" | ||
# Test if pkg-config is available to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Rtools always have pkg-config? If so, we can probably simplify things here since there's only one way to build on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rtools43 does, not sure about older versions
|
Co-authored-by: Neal Richardson <[email protected]>
We don't, since we added checksum verification in #37941 we use the artifactory for windows too. |
I think for CRAN submission we should use rwinlib. |
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e1241e7. There was 1 benchmark result with an error:
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
…ows (apache#39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: apache#39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…ows (apache#39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: apache#39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…ows (apache#39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: apache#39987 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Neal Richardson <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version.
These changes can't be tested, there are no user facing changes for now.