-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sh usages #122
Remove sh usages #122
Conversation
78df7b4
to
00d3816
Compare
@gotmax23 the failing tests show a problem with
This requires a very large output, which apparently happens for According to the asyncio/streams.py in Python 3.10, the default limit is 65536 bytes for a line. This can be adjusted by passing |
I've tried it out in ansible-community/antsibull-core#53, it seems to work well. |
c005f1b
to
5a387fd
Compare
Restarting tests now that ansible-community/antsibull-core#53 has been merged. |
(Rebased to remove conflict.) |
Thanks for working on this! I'll take a closer look later today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is pretty straightfoward; I just have a couple comments 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Let's do this 🎉!
@gotmax23 thanks for preparing this and reviewing! |
Needs to be rebased/updated once #120 has been merged.