Drop dependency on sh #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felixfontein
force-pushed
the
sh
branch
3 times, most recently
from
ce4353f to
f3ebb64
Compare
felixfontein
commented
Apr 19, 2023
gotmax23
reviewed
May 3, 2023
|
After we merge this, can we reformat the codebase with black and isort? |
I would also finish and merge #477 first, since it's almost done. |
Co-authored-by: Maxwell G <[email protected]>
gotmax23
approved these changes
May 4, 2023
|
Thanks for working on this! |
Co-authored-by: Maxwell G <[email protected]>
|
@gotmax23 thanks a lot for preparing and reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ansible-community/antsibull-docs#122. Let's remove the direct dependency on
sh!(I think we should do another release before merging this, so that the release role changes get out. This PR should only end up in a release once antsibull-core 2.0.0 is out and we can depend on it. I'm marking this PR as draft because of that.)