-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around line length limit of asyncio.StreamReader #53
Conversation
FWIW, subprocess_tee, which somewhat inspired this implementation, sets STREAM_LIMIT = 2**23 # 8MB instead of default 64kb, override it if you need Setting some limit means we don't have to complicate this code, and also, I don't think the logger can't handle unlimitted line lengths. See #52 (comment). |
That sounds like a huge hack, and something we should absolutely not do.
No, but I don't think we should decide what the logger can handle and what not. We should pass on what the program returns, no matter what it is (as long as it fits in memory). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'm convinced. This looks good to me, but I have one question. Thanks!
This reverts commit f5536e8.
@gotmax23 thanks for reviewing this! |
Fixes the problem mentioned in ansible-community/antsibull-docs#122 (comment).