Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CLI balance queries #3171

Merged
merged 15 commits into from
May 9, 2024
Merged

Rework CLI balance queries #3171

merged 15 commits into from
May 9, 2024

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented May 3, 2024

Describe your changes

Closes #3014

All balance queries now expect a token and an owner parameter.

Remove unbounded balance queries, where either (or both) token and owner parameters could be omitted from the CLI args. We also remove unbounded IBC token queries: the SDK's functionality to query them remains untouched, but it is no longer exposed from the CLI.

Indicate on which release or other PRs this topic is based on

#3142 (at 5268b6d; remove this commit and rebase on origin/grarco/remove-pin-key or a later release with the dep, eg v0.35.0, when cutting a release with this PR)

Diff for review: https://github.com/anoma/namada/compare/5268b6de791e2db48d6c979c4f97e92658b3c171..fraccaman/rework-balance

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

sug0 added a commit that referenced this pull request May 3, 2024
@sug0 sug0 marked this pull request as ready for review May 3, 2024 09:40
@sug0
Copy link
Collaborator Author

sug0 commented May 3, 2024

gaia is missing in this branch -.-

@sug0 sug0 marked this pull request as draft May 3, 2024 10:02
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 59.62%. Comparing base (9d4de02) to head (65ce1d7).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 29 Missing ⚠️
crates/core/src/masp.rs 0.00% 5 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 1 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 1 Missing ⚠️
crates/namada/src/ledger/native_vp/ibc/context.rs 0.00% 1 Missing ⚠️
crates/shielded_token/src/storage_key.rs 0.00% 1 Missing ⚠️
crates/tx_prelude/src/ibc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
+ Coverage   59.40%   59.62%   +0.21%     
==========================================
  Files         298      298              
  Lines       92326    91988     -338     
==========================================
+ Hits        54849    54850       +1     
+ Misses      37477    37138     -339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman
Copy link
Member

rebase on base to get gaia :)

@sug0
Copy link
Collaborator Author

sug0 commented May 3, 2024

rebase on base to get gaia :)

@Fraccaman I'm based on #3142, but its base is outdated (before origin/base), and it has already been merged to draft... maybe I can merge origin/base to fix CI?

sug0 added a commit that referenced this pull request May 3, 2024
@sug0 sug0 force-pushed the fraccaman/rework-balance branch from ca80e5c to 0d40c77 Compare May 3, 2024 16:59
@sug0
Copy link
Collaborator Author

sug0 commented May 3, 2024

Changed the base to 5268b6d, which is origin/grarco/remove-pin-key merged with origin/base

@sug0 sug0 force-pushed the fraccaman/rework-balance branch from e6488ac to 65ce1d7 Compare May 6, 2024 13:05
@sug0
Copy link
Collaborator Author

sug0 commented May 6, 2024

@yito88 I'm not sure why, but run_ledger_ibc_with_hermes is failing in this PR. There is some issue with hermes...

@sug0 sug0 marked this pull request as ready for review May 6, 2024 13:38
@yito88
Copy link
Member

yito88 commented May 6, 2024

#3142 requires updating Hermes.
In my env, run_ledger_ibc_with_hermes passed.
https://github.com/heliaxdev/hermes/tree/1.7.4-namada-3142

@sug0
Copy link
Collaborator Author

sug0 commented May 6, 2024

I see. thanks!

brentstone added a commit that referenced this pull request May 7, 2024
* fraccaman/rework-balance:
  Changelog for #3171
  Fix integration tests
  Standardize no balance response
  Improve error msg when no balance owner is found
  Remove `get_token_balance` from apps
  Remove IBC token query command
  Refactor the CLI's balance command
brentstone added a commit that referenced this pull request May 8, 2024
* origin/fraccaman/rework-balance:
  Changelog for #3171
  Fix integration tests
  Standardize no balance response
  Improve error msg when no balance owner is found
  Remove `get_token_balance` from apps
  Remove IBC token query command
  Refactor the CLI's balance command
@brentstone brentstone merged commit 51cc9a2 into main May 9, 2024
15 of 19 checks passed
@brentstone brentstone deleted the fraccaman/rework-balance branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor namadac balance
5 participants