Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor namadac balance #3014

Closed
2 of 3 tasks
brentstone opened this issue Apr 6, 2024 · 2 comments · Fixed by #3171
Closed
2 of 3 tasks

Refactor namadac balance #3014

brentstone opened this issue Apr 6, 2024 · 2 comments · Fixed by #3171
Assignees
Labels

Comments

@brentstone
Copy link
Collaborator

brentstone commented Apr 6, 2024

  • Require the owner argument, as the current impl without this arg provided tries to loop over the balances of all accounts, which is way too intensive and should not be allowed
  • MASP strategy is too intensive and should be changed
  • Non-native (IBC) token strategy is also too intensive, should not be scanning over all tokens in the chain for balances.

Previous related issues:

@brentstone brentstone added this to the To evaluate milestone Apr 6, 2024
@brentstone
Copy link
Collaborator Author

@Fraccaman @cwgoes I think this should probably be a Phase 1 priority, what do you think?

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

Decisions 2024.04.24:

  • Require --owner always (which will be a transparent or shielded address)
    • Implies shielded/transparent
  • Require --token always
  • Clean up / clarify error messages
  • Clarify in the description what the command does and does not do
    • Does not scan all tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants