Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to Improve Query Performance by Removing Redundant Code #2887

Closed
duyhla opened this issue Mar 12, 2024 · 3 comments
Closed

Proposal to Improve Query Performance by Removing Redundant Code #2887

duyhla opened this issue Mar 12, 2024 · 3 comments

Comments

@duyhla
Copy link

duyhla commented Mar 12, 2024

Improve balance query #2886

Upon reviewing our codebase, I've noticed that querying transparent balances might not always be necessary, and it could significantly slow down the overall process due to the large amount of data involved. Therefore, I suggest removing the section of code responsible for querying transparent balances entirely.

By removing the call to query_transparent_balance and query_shielded_balance, we can potentially improve the overall performance of our querying process, especially when dealing with large datasets. This optimization ensures that we only query the balances that are essential for our operations, thus reducing unnecessary processing time and resource consumption.

@ntnguyen147
Copy link

I also had the same error, when I removed it the log improved quite significantly. Thank you so much

@encipher88
Copy link

Because namadac balance show all address in network, use --owner alias

It's useful. I run "namadac balance" and get over 10 GB response. My node is lagging and got stuck. My network also slows down.

@brentstone
Copy link
Collaborator

Closing, as progress here will be tracked in #3014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants