Remove MASP pin key #2675
Assignees
Labels
breaking:consensus
Consensus breaking change that requires a hard-fork
MASP
pre-mainnet
Must happen before mainnet.
Milestone
Comments
37 tasks
|
In the end, after some talk we decided to remove the pin key and focus on developing a better implementation of the shielded sync process #2900. cc: @Fraccaman, @batconjurer |
|
In that case I'm going to close this issue. |
|
Reopening as this has not been completed yet |
|
I see, sorry, it wasn't clear to me what task needed to be completed. Updated the title to clarify. |
grarco
added
the
breaking:consensus
brentstone
added a commit
that referenced
this issue
Apr 30, 2024
* grarco/remove-pin-key: Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this issue
May 7, 2024
* grarco/remove-delta-map: Changelog #3172 Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this issue
May 8, 2024
* origin/grarco/remove-pin-key: Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this issue
May 8, 2024
* origin/grarco/remove-delta-map: Changelog #3172 Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this issue
May 9, 2024
* origin/grarco/remove-pin-key: Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this issue
May 9, 2024
* origin/grarco/remove-delta-map: Changelog #3172 Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the masp optional pin key is used in an inconsistent way: when a user generates a payment address there’s the chance to pin this address, if this is the case than all transactions with this payment address as the receiver will produce a pin key with the hash of the address, otherwise no pin key will be produced. If no pin is requested when generating the address, then no pin key will be produced.
Also, since we produce the pin key in a deterministic way (hash of the payment address) I believe we end up rewriting the same key in storage.
The text was updated successfully, but these errors were encountered: