Remove delta map #3172
Merged
Remove delta map #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk with the balance keys
grarco
force-pushed
the
grarco/remove-delta-map
branch
from
6d2dec9 to
0ae083b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
==========================================
+ Coverage 59.40% 59.76% +0.36%
==========================================
Files 298 298
Lines 92326 91769 -557
==========================================
Hits 54849 54849
+ Misses 37477 36920 -557 ☔ View full report in Codecov by Sentry. |
batconjurer
approved these changes
May 6, 2024
|
@yuji does this need a hermes update for |
@brentstone not this pr but the one on which it's based, see here #3142 (comment) |
brentstone
added a commit
that referenced
this pull request
May 7, 2024
* grarco/remove-delta-map: Changelog #3172 Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/grarco/remove-delta-map: Changelog #3172 Removes `delta_map` from the `ShieldedContext` and all the code to work with the balance keys Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Extends #3142 by removing the unused
delta_map. Also refactors/removes functions dealing with the balance keys.Indicate on which release or other PRs this topic is based on
#3142 rebased on the tip ob base (diff for review: https://github.com/anoma/namada/pull/3172/files/2a25031ec579b802a0af75cff1ccbd08c8905c88..0ae083b7c347f2de353bc8b0dc1ee31baa1b3be6)
Checklist before merging to
draft