Murisi/restructure tx draft #1462
Conversation
…fying Txs as InnerTxs.
…tomas/improve-cli-commission-rate' and 'tomas/rename-tx-reveal-arg' (#1431, #1432, #1434, #1436) * tomas/rm-empty-keys-mod: app/wallet: rm empty keys mod * tomas/missing-args-def: cli: add missing `--wallet-alias-force` and `--alias-force` * tomas/improve-cli-commission-rate: shared/tx/submit_validator_commission_change: print err even with force * tomas/rename-tx-reveal-arg: cli: rename Tx arg `tx_code_path` to `tx_reveal_code_path`
* tomas/fix-err-typos: shared/tx: fix err variant typos
Namada 0.15.4 * tag 'v0.15.4': Namada 0.15.4 changelog: add #1407 Fixes e2e tests changelog: add #1399 Tendermint consensus params settable in Namada config Updates `InternalStats` display changelog: add #1405 process_proposal: fix typos in test names prepare_proposal: add replay protection tests Adds replay protection checks in prepare_proposal Logs validation error in `process_proposal`
* aleks/wallet-zeroize: [ci] wasm checksums update Add changelog fix: zeroize passphrases
* tiago/main/rm-abciplus-cargo-deps: Remove ABCI++ commands from the Makefile Update Cargo lock file Remove ABCI++ deps from Cargo files Revert "Makefile: Add arguments to e2e tests" Revert "Makefile: `NAMADA_E2E_USE_PREBUILT_BINARIES` default" Makefile: `NAMADA_E2E_USE_PREBUILT_BINARIES` default Makefile: Add arguments to e2e tests Makefile: `NAMADA_E2E_USE_PREBUILT_BINARIES` default Makefile: Add arguments to e2e tests fix: ci run with maint-* target branch Remove accidental artifact Apply suggestions from code review missed spelling mistakes fixed a bunch of typos and attended comments Update documentation/specs/src/base-ledger/governance.md added incentives for stewards somg governance changes fixed some governance ya dig slight fix ammendments that will need ammending proposals named correctly no more mentions of the council new changes some changes to pgf specs
…st vector generation.
|
pls update wasm |
| /// Transaction data that needs to be sent to hardware wallets | ||
| Data(Data), | ||
| /// Transaction data that does not need to be sent to hardware wallets | ||
| ExtraData(Code), |
There was a problem hiding this comment.
Is this meant to be ExtraData(Code)?
| ExtraData(Code), | |
| ExtraData(Data), |
There was a problem hiding this comment.
Yes, it is meant to be ExtraData(Code). The reason why is that the extra data section shares a greater resemblance to the the code section than it does to the data section. More specifically, extra data sections frequently contain too many bytes, just like the WASM code in code sections are frequently too large. Hence both extra data and code sections are "compressed" by first taking the SHA-256 hash of their payload and putting that into the section instead. This is in contrast to the data section, which is mostly unique to each transaction, and is never compressed because hardware wallets need to render all contained data (which would not be possible with just a hash).
| /// A transaction timestamp | ||
| pub timestamp: DateTimeUtc, | ||
| /// The SHA-256 hash of the transaction's code section | ||
| pub code_hash: crate::types::hash::Hash, |
There was a problem hiding this comment.
This may be a privacy concern, as mentioned by @Fraccaman
There was a problem hiding this comment.
The code_hash field of Header is salted. That is, the WASM code hash is appended to a salt, and then hashed in order to not reveal what kind of transaction is being done. See:
namada/core/src/proto/types.rs
Line 162 in 11a272b
This is an attempt to achieve #1255 with the tip of
mainmerged in. Overall the main changes introduced by this branch are:Txobject instead of a data byte vector. This is because the data section's signature is stored in a different section, and because the extradataalso resides in a separate section.Txs where the auxiliary inputs that were used to construct a MASP transaction can be stored. This may be useful for hardware wallets when validating a given Transaction object.Additional notes: