Skip to content

Commit

Permalink
Merge branch 'origin/murisi/restructure-tx-draft' (#1462)
Browse files Browse the repository at this point in the history
* origin/murisi/restructure-tx-draft:
  [ci] wasm checksums update
  Fixed clippy issues and formatting. Added an std feature to enable test vector generation.
  Removed the unchecked and epoch flags since not all test vector generation is online.
  Fixed online test vector generation.
  Fixed the generation of test vectors for IBC transfers.
  Renamed CodeHash to Commitment to reflect its general usage.
  Corrected ther serialization of ciphertexts to account for length-prefixes.
  Removed unnecessary masp_proofs dependency from WASM modules.
  Fixed deprecated call to to_extended_full_viewing_key. Now combine sections before encrypting them.
  Update scripts/online_generator.sh
  Update scripts/offline_generator.sh
  vm_env: removed accidentally revived token mod
  tx_prelude: remove accidentally revived gov mod
  tx/pos: drop misformatted seed
  core/transaction: box wrapper and protocol tx type variants
  make fmt
  core/types/proto: docstring fix
  core/proto/types: docstring fix
  test: update for tx API changes
  test/shell/finalize_block: update test_undecryptable_returns_error_code
  client: remove accidentally revived types file
  client/cli: look-up token aliases from wallet
  cli: add conflicts_with UNCHECKED on FORCE and re-order
  more clippy fixes
  cargo: use "rev" instead of branch name for masp
  Applied cargo fmt and clippy.
  Simplified the TxInQueue data structure.
  Move chain id and expiration information into the header.
  Increased the maximum proposal code size to 500000 so that proposal test can pass.
  Improved the formatting of test vectors.
  Added some bash scripts to generate test vectors.
  Added asset type decodings to the MaspBuilder section. Now use readable token name in Ledger vectors.
  Added code to add transaction debug outputs. Started decoding MASP transactions.
  Added code to save transactions if NAMADA_LEDGER_LOG_PATH enabled.
  Simplified hashing so that its mostly based on Borsh.
  Added function to convert Namada transaction to Ledger vector.
  Added CLI flag to disable checks during transaction construction.
  Allow the transaction code section to be contracted.
  Now attach a Builder instance to Txs.
  Created a new Builder section to witness for Transaction sections.
  Exclude signatures from MaspTx section hash so that references to it are not invalidated.
  Separated header validation from header extraction.
  Make proof reading during transaction validation safe.
  Upgraded the version of the MASP crate that is used.
  Make it easier to update transaction headers.
  Added some documentation to the new Tx structure.
  Deduplicatedd encryption code and tailored it for Section structure.
  Removed the Signed structure as its not currently being used.
  Removed unnecessary fields in Tx. Cleaned up Transfer event creation code.
  Re-enabled submission of proposal code.
  Move shielded transactions out of Transfer and into Tx.
  Removed redundant InnerTx usages.
  Flattened Tx and InnerTx into one structure.
  Reduced usage of InnerTx.
  Replaced the inner_tx of Tx with InnerTx fields.
  Renamed outer Tx fields in protobuf to avoid ambiguities.
  Moved out the InnerTx nested in the header.
  Made outer Tx data non-optional.
  Now supply Vps and Txs with full transactions.
  Renamed the fields of outer transaction to avoid confusion.
  Restricted the contents of the data field of Tx.
  Separated SignedOuterTxData from SignedTxData. This involved reclassifying Txs as InnerTxs.
  Strengthened the typing of the Tx data field with SignedTxData.
  Made transaction data optional.
  Gave inner_tx a stronger type.
  Removed encryption from transactions.
  Aligned the signing of reveal transactions with that of other transactions.
  Reduced the size of InitValidator transactions.
  Add an extra data field to Txs that is hashed before signing.
  [ci] wasm checksums update
  Removed inner_tx_code since it is redundant when with inner_tx.
  Renamed WrapperTxInQueue to TxInQueue to be more accurate.
  [ci] wasm checksums update
  Fixed formatting and clippy.
  Added more error handling and streamlined (de)serialization code.
  Hash the inner transaction code before placement inside wrapper.
  Recombined Tx and SigningTx.
  Moving inner_tx from WrapperTx to Tx.
  • Loading branch information
Fraccaman committed Jun 5, 2023
2 parents 49e9aa3 + 11a272b commit 917eaa4
Show file tree
Hide file tree
Showing 111 changed files with 6,052 additions and 4,679 deletions.
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/1093-signable-txs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Make Namada transactions signable on hardware constrained wallets by making
them smaller. ([#1093](https://github.com/anoma/namada/pull/1093))
2 changes: 0 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ on:
push:
branches:
- main
- maint-*
- "!eth-bridge-integration"
# Run in PRs with conflicts (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request)
pull_request_target:
branches:
- main
- maint-*
- "!eth-bridge-integration"
types: [opened, synchronize, reopened]
workflow_dispatch:
Expand Down
Loading

0 comments on commit 917eaa4

Please sign in to comment.