-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/restructure tx merge #1313
Conversation
…fying Txs as InnerTxs.
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Thanks, this merge is fine. However, if I remember correctly the only failing jobs in the CI were due to the 3 MASP E2E tests failing, and I identified that to be due to the CI configuration. See #1376 . That being said, there are some E2E tests (that are not executed by the CI) that are failing for me locally:
Do you have any ideas on what might be the cause? Thanks! |
…ctions before encrypting them.
2c659dd
to
81ac30f
Compare
81ac30f
to
db17079
Compare
Subsumed by #1462 . |
This is an attempt to achieve #1255 with the tip of
main
merged in. Overall the main changes introduced by this branch are:Tx
object instead of a data byte vector. This is because the data section's signature is stored in a different section, and because the extradata
also resides in a separate section.Tx
s where the auxiliary inputs that were used to construct a MASP transaction can be stored. This may be useful for hardware wallets when validating a given Transaction object.Additional notes: