Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better check on attribute length #80

Merged
merged 1 commit into from
Mar 2, 2022
Merged

feat: better check on attribute length #80

merged 1 commit into from
Mar 2, 2022

Conversation

morrieinmaas
Copy link
Contributor

Signed-off-by: morrieinmaas [email protected]

@berendsliedrecht berendsliedrecht merged commit a0b70ab into main Mar 2, 2022
@berendsliedrecht berendsliedrecht deleted the feat/better-length-check branch March 2, 2022 21:03
@morrieinmaas
Copy link
Contributor Author

Got a nice message from the compiler about this being better

@berendsliedrecht
Copy link
Member

Should automate clippy on push maybe..

jl-animo pushed a commit that referenced this pull request Mar 4, 2022
@jloleysens
Merge branch 'main' into feat/expand-help-strings
d2a1817 
* main:
  fix: config path for windows OS (#75)
  feat: better check on attribute length (#80)
  fix: improved error message for config and connection without flag (#74)
  fix: print the connection id (#77)
  fix: schema requires attributes (#78)
  fix: american english (#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berendsliedrecht berendsliedrecht Awaiting requested review from berendsliedrecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morrieinmaas @berendsliedrecht