Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema requires attributes #78

Merged
merged 2 commits into from
Mar 2, 2022
Merged

fix: schema requires attributes #78

merged 2 commits into from
Mar 2, 2022

Conversation

berendsliedrecht
Copy link
Member

closes #62

Signed-off-by: Berend Sliedrecht [email protected]

@berendsliedrecht
fix: schema requires attributes
132af78 
Signed-off-by: Berend Sliedrecht <[email protected]>
TimoGlastra
TimoGlastra reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

cli/src/error.rs Outdated Show resolved Hide resolved
@berendsliedrecht @TimoGlastra
Update cli/src/error.rs
9953bff 
Co-authored-by: Timo Glastra <[email protected]>
@berendsliedrecht berendsliedrecht merged commit 2bba0e7 into main Mar 2, 2022
@berendsliedrecht berendsliedrecht deleted the fix/required-attributes branch March 2, 2022 07:59
jl-animo pushed a commit that referenced this pull request Mar 4, 2022
@jloleysens
Merge branch 'main' into feat/expand-help-strings
d2a1817 
* main:
  fix: config path for windows OS (#75)
  feat: better check on attribute length (#80)
  fix: improved error message for config and connection without flag (#74)
  fix: print the connection id (#77)
  fix: schema requires attributes (#78)
  fix: american english (#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra left review comments

@morrieinmaas morrieinmaas Awaiting requested review from morrieinmaas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--attributes should be required for schema create command
2 participants
@berendsliedrecht @TimoGlastra