-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config path for windows OS #75
Conversation
It's WIP @blu3beri . Need to test that first. Windows VM being a right b*** atm. |
Signed-off-by: morrieinmaas <[email protected]>
31fdd7f
to
c7996c1
Compare
4d35750
to
fa3e523
Compare
Signed-off-by: morrieinmaas <[email protected]>
fa3e523
to
a8a3b1a
Compare
Signed-off-by: morrieinmaas <[email protected]>
Approved when tested. |
Signed-off-by: morrieinmaas <[email protected]>
Signed-off-by: morrieinmaas <[email protected]>
@blu3beri Just a little update:
The bad news:
I'll continue to figure this out (now that I have a WIndows machine up and running). Just have no clue how Windows works so need to do some digging. On another note, I needed to install some dependencies like C++ compiler/build env for windows for this to compile in the first place. Maybe we can open a ticket about this. I'm just not sure how to articulate this properly (yet) as again I don't know how windows works and how to define dependencies for a rust project for windows compile or whether to just set that in the README and let people know and then that's enough.🤷♂️😅 |
Okay, yeah the %...% was a small chance that it would work. It is the same as how "~" works in unix, in the sense that it expands to another full path, like On the compiling step, it is not really a problem. People who want to contribute to a rust project must deal with them themselves, like with any language. And the binary comes, 99.999% sure, with all the bells and whistles to work. I do think the error about home not being specified is odd. Could you send a screenshot of that? |
This works with WSL and Powershell Signed-off-by: morrieinmaas <[email protected]>
@blu3beri let me know if you have any more feedback. This works now for windows (and doesn't break unix. One thing I see is we can probably extract the logic for path creation to the config file inot a function as it's the same code in 2 places now. Can do that here or in another PR. (or not at all if you don't see fit) |
Signed-off-by: morrieinmaas <[email protected]>
Signed-off-by: morrieinmaas <[email protected]>
Only create path for unix and windows. Throw and error if neither OS type can be detected. Signed-off-by: morrieinmaas <[email protected]>
ba140b3
to
a02a871
Compare
Alright @blu3beri |
Signed-off-by: morrieinmaas <[email protected]>
a02a871
to
c882d7c
Compare
Signed-off-by: morrieinmaas [email protected]
closes #54