Upgrade Closure Compiler to v20171112 #18552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
changed the title
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
d1ef268
to
36d913d
Compare
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
36d913d
to
600e8f9
Compare
added 2 commits
October 5, 2018 11:42
… add comment about jscomp_warning.
|
@choumx why does compiler-and-tests.jar need to be updated? |
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
e62defa
to
43de67c
Compare
|
/to @erwinmombay @rsimha /cc @cramforce |
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
43de67c
to
84088d2
Compare
dreamofabear
force-pushed
the
cc-2017-10-23
branch
2 times, most recently
from
ef87609
to
a883acd
Compare
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
a883acd
to
4569c93
Compare
added 3 commits
October 6, 2018 02:47
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
dd6129e
to
f3c398b
Compare
dreamofabear
force-pushed
the
cc-2017-10-23
branch
from
f033713
to
4c251f9
Compare
|
Merged for you since this could easily get into merge conflicts. |
|
How hard would it be to upgrade to something actually current? |
|
Thanks for the merge! It took me two days to upgrade six months with learning curve, so maybe less than a week for another year's worth (11/2017 to 10/2018). |
This was referenced Oct 7, 2018
Merged
dreamofabear
pushed a commit
that referenced
this pull request
Oct 10, 2018
* Revert "Revert CC upgrade. (#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
* Revert "Revert CC upgrade. (ampproject#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Revert "Revert CC upgrade. (ampproject#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades CC from 20170409 to 20171112.
google/closure-compiler#2418 enables transpilation of superclass property refs e.g.
super.foo, which is used byworker-dom. Earliest version after that PR is 20170626.However, non
goog.moduleimports are broken until 20171023 with google/closure-compiler#2641, so upgrade to that instead.However, 20171023 changes "module not found" from warning to error (problematic for
swg.js), so upgrade to 20171112 which allows demoting them back to warnings via google/closure-compiler#2694.Remaining issues
swg.jsthat can't be suppressed for some reason. To fix these, we should generate externs or strip bogus type annotations with relative paths. To unblock, Ichanged the build to not fail on warnings from swg.jssearch/replaced those types to*via regex. Filed Type paths to missing files in swg.js #18586.Updating Closure Compiler
third_party/closure-compiler/compiler.jar, download desired binary.compiler-and-tests.jar, clone closure-compiler and build it manually. Steps to make sure test classes are included:test/intosrc/.<scope>test</scope>in dependencies.<minimizeJar>true</minimizeJar>inpom-main-shaded.xml.compiler-and-tests.jar.ant jarandant test. Fix stuff, cross-reference diffs in code search to dig up deprecations etc.