Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗✨ Upgrade closure compiler to v20190513 #22446

Merged
merged 7 commits into from
May 22, 2019
Merged

🏗✨ Upgrade closure compiler to v20190513 #22446

merged 7 commits into from
May 22, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 22, 2019

This PR upgrades the version of closure compiler used to minify the AMP runtime to v20190513.

Highlights:

Future work: Dynamically generate runner.jar once we no longer need a custom built compiler.jar (#22452)

Companion to #22368
Partial fix for #18748
Follow up to #18552, #18609, #18794, #19449, #20056, and #21618

@rsimha
Copy link
Contributor Author

rsimha commented May 22, 2019

Tested this as follows:

  • Minified build is green (link)
  • Type checker is green (link)
  • Running time for gulp dist is unaffected (link)
  • Zero visual diffs (link)
  • Single pass build and tests are green (link)
  • Local and remote tests all green (link, link)
  • Size of v0.js and number of instances of the string assert remain unchanged with 2a45d76
  • Manually sanity checked the runtime + extensions in multi pass and single pass modes
  • Source maps continue to work with this verification tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants