-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗✨ Upgrade closure compiler to v20190513 #22446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
May 22, 2019
build-system/runner/src/org/ampproject/AmpCodingConvention.java
Outdated
Show resolved
Hide resolved
Tested this as follows:
|
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the version of closure compiler used to minify the AMP runtime to
v20190513
.Highlights:
compiler.jar
with a custom built version based onv20190513
goog.requireType
or TSimport type
google/closure-compiler#3041 is fixed)compiler-and-tests.jar
with a custom built version based onv20190513
runner.jar
after fixing code and tests to be compatible with latest compiler code@closurePrimitive
annotations for assertion functionsgetAssertionFunctions()
override inAmpCodingConvention.java
Future work: Dynamically generate
runner.jar
once we no longer need a custom builtcompiler.jar
(#22452)Companion to #22368
Partial fix for #18748
Follow up to #18552, #18609, #18794, #19449, #20056, and #21618