Allow Module Load errors to be suppressed #2694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatrixFrog
reviewed
Oct 30, 2017
| @@ -149,8 +150,9 @@ public DiagnosticGroup forName(String name) { | |||
| + "underscore, " | |||
| + "visibility"; | |||
|
|
|||
| public static final DiagnosticGroup COMMON_JS_MODULE_LOAD = | |||
| DiagnosticGroups.registerGroup("commonJsModuleLoad", | |||
There was a problem hiding this comment.
If anyone already has @suppress {commonJsModuleLoad} in their code then they'll have to change it, right? We should mention that in the release notes when we bring this in.
There was a problem hiding this comment.
I did consider that - just didn't like even more groups.
Alternatively I can add a new one and remove the commonJs specific one from the advertised list.
There was a problem hiding this comment.
Sounds good, we can just note it in the release notes.
|
As it happens, I recently had to add |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes promoted the ModuleLoader warnings for missing modules to errors. I need these to be suppressible now for certain cases. This reworks the commonJsModuleLoad diagnostic group to be just a general moduleLoad group so that they can be managed.