Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification channels #40

Closed
11 of 12 tasks
alexjustesen opened this issue Oct 3, 2022 · 44 comments
Closed
11 of 12 tasks

Notification channels #40

alexjustesen opened this issue Oct 3, 2022 · 44 comments
Assignees
Labels
🎉 feature New feature or request

Comments

@alexjustesen
Copy link
Owner

alexjustesen commented Oct 3, 2022

When a notification is triggered it should be sent to a channel so that the user is notified of the thing.

Supported channels should will include:

@jpslv
Copy link

jpslv commented Oct 29, 2022

This app is really awesome and a nice "upgrade" over others that are available but outdated on unRAID. Would love to have discord notifications. Is it possible?

@alexjustesen
Copy link
Owner Author

This app is really awesome and a nice "upgrade" over others that are available but outdated on unRAID. Would love to have discord notifications. Is it possible?

Discord is already on the list 😉, also this reminds me I'll need to get this onto the unRAID Community App Store

@jpslv
Copy link

jpslv commented Oct 29, 2022

I've installed today this one on my unRAID server.

image

@jpslv
Copy link

jpslv commented Oct 29, 2022

And thank you so much for the Discord feature!

@alexjustesen
Copy link
Owner Author

I've installed today this one on my unRAID server.

Right after I posted that I saw someone created the app, nice to see the unRAID community here!

@mztiq
Copy link

mztiq commented Nov 21, 2022

Thanks for reviving this project, I'm happy to see all this progress!
Any chance for Ntfy notification implementation? It works pretty similar to Gotify, alternatively some kind of curl notifications would be great too.

@alexjustesen
Copy link
Owner Author

Thanks for reviving this project, I'm happy to see all this progress!
Any chance for Ntfy notification implementation? It works pretty similar to Gotify, alternatively some kind of curl notifications would be great too.

Ntfy sounds good so can do, also what do you mean about a curl notification?

@mztiq
Copy link

mztiq commented Nov 22, 2022

That'd be awesome!
Ntfy also supports notifications via curl as described here, that's what I meant.

@gf78
Copy link

gf78 commented Jan 20, 2023

Proposal: add generic webhook notification. users can add get urls, these are requested in case of a notification. values are added as query.

this gives users more flexibility to trigger actions in their own systems

@alexjustesen
Copy link
Owner Author

Proposal: add generic webhook notification. users can add get urls, these are requested in case of a notification. values are added as query.

this gives users more flexibility to trigger actions in their own systems

Added to the list

@hctrr
Copy link

hctrr commented Jan 23, 2023

proposal: add support for apprise
Apprise allows you to send a notification to almost all of the most popular notification services available to us today such as: Telegram, Discord, Slack, Amazon SNS, Gotify, etc.

@alexjustesen
Copy link
Owner Author

proposal: add support for apprise Apprise allows you to send a notification to almost all of the most popular notification services available to us today such as: Telegram, Discord, Slack, Amazon SNS, Gotify, etc.

In another issue we chatted a little bit about Apprise and integrating it with Speedtest Tracker. At this time (because I don't want to have an intermediary container) it's not going to be prioritized. Ref: #277 (comment)

@alexjustesen alexjustesen unpinned this issue Jan 29, 2023
@shiftylilbastrd
Copy link

Pushover would be a great addition as well

@ilsaul
Copy link

ilsaul commented Feb 6, 2023

@alexjustesen I appreciate your idea to integrate many notification systems but apprise with one REST call realizes several notification systems. In a short time you can integrate it compared to the time it takes to integrate any of the other systems. You can also think that by integrating an external system when someone ask you to add a new system you can always reply to see if Apprise supports it while you integrate other things.

@alexjustesen
Copy link
Owner Author

@alexjustesen I appreciate your idea to integrate many notification systems but apprise with one REST call realizes several notification systems. In a short time you can integrate it compared to the time it takes to integrate any of the other systems. You can also think that by integrating an external system when someone ask you to add a new system you can always reply to see if Apprise supports it while you integrate other things.

#277 (comment)

@masterwishx
Copy link

@alexjustesen Sorry , cant find if notifications (mostly interested Discord) is added to milestones ?

@alexjustesen
Copy link
Owner Author

@alexjustesen Sorry , cant find if notifications (mostly interested Discord) is added to milestones ?

Not yet, list at the top is accurate.

@masterwishx
Copy link

OK, Thanks will wait ... :)

@alexjustesen
Copy link
Owner Author

Hi! Great work. Wondering if you can help me with an issue I am experiencing. When I setup the mail notification, I never receive the email. I have checked all spam filters/folders I have and I don't see the email I am expecting when I click the test button in the Mail sections of the notifications page. I am using a known good email configuration via Sendgrid. Which I have setup on other tools and apps I have running in my environment.

Can you do me a favor and start a discussion on your issue? This issue I'm using to track progress on features and don't want to have multiple topics.

@blusls79
Copy link

Sorry about that, and done.

@viriatusX
Copy link

Good evening.
Any ETA to implement notifications with Discord? Thank you very much 🙏

@grosejon
Copy link

I used to use Notifiarr with the old speedtest tracker, and that worked really well. The notifications ended up in Discord which made it very easy.

@jonezy35
Copy link
Contributor

Has there been much interest in the Slack notification channel? Now that I figured out Discord (assuming that's good to be merged) I could pivot to Slack now that I have an understanding of the notification functionality.

@crispybegs
Copy link

Has there been much interest in the Slack notification channel? Now that I figured out Discord (assuming that's good to be merged) I could pivot to Slack now that I have an understanding of the notification functionality.

i used to have my speed results delivered to slack every day on one of the old versions and was quite sad when it vanished, so yes I'd love it back

@jonezy35
Copy link
Contributor

Has there been much interest in the Slack notification channel? Now that I figured out Discord (assuming that's good to be merged) I could pivot to Slack now that I have an understanding of the notification functionality.

i used to have my speed results delivered to slack every day on one of the old versions and was quite sad when it vanished, so yes I'd love it back

Sweet assuming my PR for Discord gets merged I can see about getting Slack notifications up and running once I confirm everything is good with the current PR

@crispybegs
Copy link

Has there been much interest in the Slack notification channel? Now that I figured out Discord (assuming that's good to be merged) I could pivot to Slack now that I have an understanding of the notification functionality.

i used to have my speed results delivered to slack every day on one of the old versions and was quite sad when it vanished, so yes I'd love it back

Sweet assuming my PR for Discord gets merged I can see about getting Slack notifications up and running once I confirm everything is good with the current PR

thank you for your service

@Magelo
Copy link

Magelo commented Feb 23, 2024

Thanks for reviving this project, I'm happy to see all this progress!
Any chance for Ntfy notification implementation? It works pretty similar to Gotify, alternatively some kind of curl notifications would be great too.

Ntfy sounds good so can do, also what do you mean about a curl notification?

image

Hi, working with Ntfy, replacing {user}, {password} and {url} with valid info works when using button "Test webhook channel" but save changes refuse to save with message "The url field must be a valid URL."

@alexjustesen
Copy link
Owner Author

I'm willing to bet this happens because validation doesn't trigger when testing a url but does in save.

@Magelo
Copy link

Magelo commented Feb 24, 2024

I'm willing to bet this happens because validation doesn't trigger when testing a url but does in save.

Absolutely, my point is, why the validation triggers when saving, a not valid URL? The URL is working with "Test webhook channel", in Ntfy I received the test notification.

@alexjustesen
Copy link
Owner Author

Ntfy support is planned (at some point), I would say the initial webhook scope is more intended for a simple payload and like Discord isn't meant for that.

@alexjustesen
Copy link
Owner Author

@jonezy35 when you go to do Slack (if you're still interested) I'm bring in a new pattern for notifications that hooks into the new event driven architecture.

#1264 has the new events and #1267 shows how to do this with webhooks.

@jonezy35
Copy link
Contributor

jonezy35 commented Mar 1, 2024

I'm interested! Just been real busy with work this week

@alexjustesen
Copy link
Owner Author

I'm interested! Just been real busy with work this week

No rush at all, just wanted to give you a heads up because you've been in those files.

@NightHawkATL

This comment was marked as off-topic.

@alexjustesen
Copy link
Owner Author

@NightHawkATL this PR is for the "Feature" of notification channels. If you're having a problem please open an issue to detail it out.

@abelfodil
Copy link

There's a lib to implement gotify https://github.com/VerifiedJoseph/gotify-api-php

Are we allowed to use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

No branches or pull requests