Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS Teams Notifications via Webhooks #1578

Closed
wants to merge 4 commits into from
Closed

Add MS Teams Notifications via Webhooks #1578

wants to merge 4 commits into from

Conversation

svenvg93
Copy link
Contributor

πŸ“ƒ Description

To cross Teams of the list #40

πŸͺ΅ Changelog

βž• Added

Add Teams to the notification page
Add Teams to the settings migration
Add a placeholder for the URL

πŸ“· Screenshots

Settings:
TeamsSettings

Results
TeamsResults

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner June 26, 2024 19:54
@svenvg93
Copy link
Contributor Author

@alexjustesen alexjustesen added the πŸ˜• help wanted Extra attention is needed label Jul 18, 2024
@alexjustesen
Copy link
Owner

Before merging I'll need to do more research if it's worth adding MS Teams if the connector is going to start failing soon.

@alexjustesen alexjustesen added the πŸŽ‰ feature New feature or request label Jul 18, 2024
@alexjustesen alexjustesen mentioned this pull request Jul 18, 2024
12 tasks
@alexjustesen alexjustesen added this to the v0.x.0 (notifications) milestone Jul 18, 2024
@alexjustesen
Copy link
Owner

@svenvg93 with MS killing off webhook support I propose we don't add MS Teams as a notification channel. If someone is using it I'm also willing to bet its a really small population.

@svenvg93
Copy link
Contributor Author

@alexjustesen sounds like a good idea. Wouldn’t be worth it to add it now indeed.

@svenvg93 svenvg93 closed this Jul 22, 2024
@svenvg93 svenvg93 deleted the 40-add-teams branch July 22, 2024 15:25
@svenvg93
Copy link
Contributor Author

@alexjustesen I do wanted to have a look to simplify the notifications as some are similar. And maybe optimize the page as well. Let me know what you think ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸŽ‰ feature New feature or request πŸ˜• help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants